Fix additionalProperties and polymorphism.#3661
Merged
shahabhijeet merged 6 commits intoAzure:psSdkJson6from Sep 7, 2017
Merged
Fix additionalProperties and polymorphism.#3661shahabhijeet merged 6 commits intoAzure:psSdkJson6from
shahabhijeet merged 6 commits intoAzure:psSdkJson6from
Conversation
olydis
force-pushed
the
fix-add-prop
branch
3 times, most recently
from
ef7299c to
aa7782c
Compare
shahabhijeet
approved these changes
Sep 7, 2017
JasonYang-MSFT
pushed a commit
to JasonYang-MSFT/azure-sdk-for-net
that referenced
this pull request
Dec 8, 2017
* repro * fix * cleanup * generate.cmd accepts actual repo name * mute mkdir output
azure-sdk
pushed a commit
that referenced
this pull request
Jul 26, 2022
This reverts commit 7605ead00308dd20f20f2afe5acc4ec9900a2c47.
azure-sdk
added a commit
that referenced
this pull request
Jul 26, 2022
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
…re#30128) This reverts commit 7605ead00308dd20f20f2afe5acc4ec9900a2c47. Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3648
Problem: Additional properties were neither serialized nor deserialized as reproed in the added test case (see first commit).
Solution: Add treatment for additionalProperties which is indicated by the
JsonExtensionDatain generated models.