Azure Stack Admin for Commerce, Fabric, and InfrastructureInsights#3649
Azure Stack Admin for Commerce, Fabric, and InfrastructureInsights#3649deathly809 wants to merge 9 commits intoAzure:psSdkJson6from
Conversation
|
@deathly809, |
shahabhijeet
left a comment
There was a problem hiding this comment.
Please have the common testbase be a separate nuget package and have all RPs take dependency on it.
have directory structure as below
src\AzureStack\TestCommon\Microsoft.AzureStack.Common.Test.csproj
Add < PackageReleaseNotes > and add Release notes.
I would recommend to use < ![CDATA and then format your Release notes
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\SDKCommon\TestCommon\TestCommon.csproj" /> |
There was a problem hiding this comment.
@deathly809 have this be a nuget dependency instead of a project reference
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\SDKCommon\TestCommon\TestCommon.csproj" /> |
There was a problem hiding this comment.
have reference to nuget package
| @@ -1,4 +1,5 @@ | |||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Import Project="SdkCommon\dirs.proj" /> | |||
| <Import Project="SDKs\dirs.proj" /> | |||
| <Import Project="AzureStack\dirs.proj" /> | |||
There was a problem hiding this comment.
you do not need this file. Please remove this file.
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
|
|
||
| <ItemGroup Label="SDKProject"> | ||
| <ProjectToBuild Include="$(MSBuildThisFileDirectory)AzureStack\FabricAdmin\Fabric.Admin\Microsoft.AzureStack.Management.Fabric.Admin.csproj" /> |
There was a problem hiding this comment.
We no longer need this file
|
@deathly809 closing this PR, as you will be opening two separate PRs. Please reopen this PR once you are ready to merge. |
Description
Initial pull request for Azure Stack Admin C# SDK containing Commerce, Fabric, and Infrastructure Insights.
Initial Swagger pull request: Azure/azure-rest-api-specs#1592
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.