Skip to content

Microsoft.Azure.Management.Storage 7.0.0#3641

Merged
shahabhijeet merged 7 commits intoAzure:psSdkJson6from
JasonYang-MSFT:7.0.0
Sep 7, 2017
Merged

Microsoft.Azure.Management.Storage 7.0.0#3641
shahabhijeet merged 7 commits intoAzure:psSdkJson6from
JasonYang-MSFT:7.0.0

Conversation

@JasonYang-MSFT
Copy link
Copy Markdown
Member

@JasonYang-MSFT JasonYang-MSFT commented Aug 31, 2017 •
edited
Loading

Description

This PR include three changes:

  1. adding SKU.list() operation, refer to swagger PR: Storage sku list operation and fix a comment to VirtualNetworkResourceId azure-rest-api-specs#1579.
  2. renaming networkAcl to networkRuleSet: Rename networkAcls to NetworkRuleSet. azure-rest-api-specs#1494.
  3. upgrade autorest to newest.

Swagger Spec: https://github.com/Azure/azure-rest-api-specs/blob/current/specification/storage/resource-manager/Microsoft.Storage/2017-06-01/storage.json

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@JasonYang-MSFT
Copy link
Copy Markdown
Member Author

JasonYang-MSFT commented Aug 31, 2017

Azure/azure-rest-api-specs#1494

@JasonYang-MSFT
Copy link
Copy Markdown
Member Author

JasonYang-MSFT commented Aug 31, 2017

Azure/azure-rest-api-specs#1579

shahabhijeet
shahabhijeet suggested changes Sep 4, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the description of this PR.
Rest Spec PR link.
Also why are you bumping up major version in a preview nuget package?

@JasonYang-MSFT
Copy link
Copy Markdown
Member Author

JasonYang-MSFT commented Sep 6, 2017

hi @shahabhijeet , Spec PR link and description are added.
There is a breaking change in this PR(renamed networkAcl to networkRuleSet).
Though this is only a preview SDK, we usually bump up major version once there is breaking change.

@shahabhijeet shahabhijeet merged commit 3ad2967 into Azure:psSdkJson6 Sep 7, 2017
JasonYang-MSFT added a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
@JasonYang-MSFT
Microsoft.Azure.Management.Storage 7.0.0 (Azure#3641)
85bec21 
* Rename networkAcls to network rule set.

* Updated tests.

* Updated version to 7.0.0

* [Storage] Adding support for SKU list operations.

* [Storage] Regenerate with generate.cmd

* [Storage]Updated test session records.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JasonYang-MSFT @shahabhijeet @msftclas