[CODE REFACTOR] - Commenting out flaky test by ro-joowan · Pull Request #3634 · Azure/azure-sdk-for-net

ro-joowan · 2017-08-30T01:52:08Z

Removing test case: DataLakeUploader_FreshFolderUploadDownload()
Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however.
Also updating the changelog.md to describe version 3.1.1-preview

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA

* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS

* I missed this file!

… into psSdkJson6

* Updating to the correct commit number: Azure/azure-rest-api-specs#1452

* Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code

… into psSdkJson6

More descriptive and fixing indent issue that was not addressed in the previous commit

More descriptive and fixing indent issue not addressed in a previous commit

Adding an important note about retrieving a list of jobs and accounts

… into psSdkJson6

* Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed.

* Adding this as a reminder to re-enable the test

… into psSdkJson6

* Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8

… into psSdkJson6

* Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however.

msftclas · 2017-08-30T01:52:12Z

@ro-joowan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

ro-joowan · 2017-08-30T02:33:14Z

Squeezing in a little update to the changelog.md in here as well!

shahabhijeet · 2017-09-03T23:29:38Z

src/SDKs/DataLake.Store/DataLakeStore.Tests/DataTransferTests/DataLakeStoreClientTests.cs

        /// Tests the case of a fresh upload with multiple segments and multiple files.
        /// </summary>
-        [Fact]
+        // [Fact]


@ro-joowan rather than commenting the attribute, you should add the skip argument, this way that test is flagged as skipped in VS as well as Build logs
[Fact(Skip="Flaky test, need to fix it")]
Or
Rather simply delete the entire test, but commenting the test is kind of makes it confusing and it's hard to discover what is not being tested in the regression suite

@shahabhijeet updated it so that it now skips. Thank you

… into psSdkJson6

* Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (Azure#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now

ro-joowan and others added 25 commits July 24, 2017 15:23

Code gen for ADLA

853090a

* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA

Code gen for ADLS

8a72cc4

* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS

Code gen for ADLS (part 2)

d0429b1

* I missed this file!

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

d97f093

… into psSdkJson6

Code gen for ADL (part 3)

0bbe518

* Updating to the correct commit number: Azure/azure-rest-api-specs#1452

Update Azure Batch to 5.1.0 (Azure#3513)

a01781f

Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519)

3793362

Fix Batch changelog references (Azure#3517)

caba128

Merge branch 'psSdkJson6' into psSdkJson6

528d017

Fixing changelog.md

2b8907f

Fixing up changelog.md

c4593fb

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

ddb1ea6

… into psSdkJson6

[DataLake Analytics] Fixing changelog.md

ee186ba

More descriptive and fixing indent issue that was not addressed in the previous commit

[DataLake Store] Fixing changelog.md

75f6a49

More descriptive and fixing indent issue not addressed in a previous commit

[DataLake Analytics] Fixing changelog.md

deb131f

Adding an important note about retrieving a list of jobs and accounts

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

398f5b5

… into psSdkJson6

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

7c8a514

… into psSdkJson6

Adding a TODO comment

5eec416

* Adding this as a reminder to re-enable the test

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

b047658

… into psSdkJson6

[CODE GEN] - Reverting readOnly for two fields

d45f70b

* Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8

[CODE GEN] - Updating the version (3.1.0 to 3.1.1)

0487521

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

7c1e6f0

… into psSdkJson6

msftclas added the cla-not-required label Aug 30, 2017

[DOC] - Updating the changelog to describe 3.1.1-preview

f9b2727

shahabhijeet suggested changes Sep 3, 2017

View reviewed changes

shahabhijeet added Changes Requested and removed Changes Requested labels Sep 3, 2017

ro-joowan added 2 commits September 5, 2017 11:06

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

69f1810

… into psSdkJson6

[CODE REFACTOR] - Skipping flaky test

c9e918e

* Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now

ro-joowan mentioned this pull request Sep 6, 2017

[BUG FIX] - Making JobInnerError object recursively defined #3666

Merged

8 tasks

Merge branch 'psSdkJson6' into psSdkJson6

2e516ca

shahabhijeet approved these changes Sep 7, 2017

View reviewed changes

shahabhijeet merged commit e93794f into Azure:psSdkJson6 Sep 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CODE REFACTOR] - Commenting out flaky test#3634

[CODE REFACTOR] - Commenting out flaky test#3634
shahabhijeet merged 29 commits intoAzure:psSdkJson6from
ro-joowan:psSdkJson6

ro-joowan commented Aug 30, 2017 •

edited

Loading

Uh oh!

msftclas commented Aug 30, 2017

Uh oh!

ro-joowan commented Aug 30, 2017

Uh oh!

shahabhijeet Sep 3, 2017

Uh oh!

ro-joowan Sep 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ro-joowan commented Aug 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

General Guidelines

Testing Guidelines

SDK Generation Guidelines

Uh oh!

msftclas commented Aug 30, 2017

Uh oh!

ro-joowan commented Aug 30, 2017

Uh oh!

shahabhijeet Sep 3, 2017

Choose a reason for hiding this comment

Uh oh!

ro-joowan Sep 6, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ro-joowan commented Aug 30, 2017 •

edited

Loading