[Cognitive Services] Makes Id/Name/Type fields of CognitiveServicesAccount readonly#3633
Merged
shahabhijeet merged 1 commit intoAzure:psSdkJson6from Aug 29, 2017
Merged
Conversation
Makes Id/Name/Type fields readonly by making set private.
Contributor
Author
|
Note: I did not update AssemblyInfo.cs nor *.csproj because we have not released 2.0.0 version and this change is in scope of 2.0.0. |
Contributor
Author
|
Consequences of Azure/azure-rest-api-specs#1589 |
shahabhijeet
approved these changes
Aug 29, 2017
JasonYang-MSFT
pushed a commit
to JasonYang-MSFT/azure-sdk-for-net
that referenced
this pull request
Dec 8, 2017
Makes Id/Name/Type fields readonly by making set private.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Id/Name/Type fields readonly by making set private.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.