Skip to content

[CODE GEN] - Reverting readOnly for two fields#3632

Merged
shahabhijeet merged 23 commits intoAzure:psSdkJson6from
ro-joowan:psSdkJson6
Aug 29, 2017
Merged

[CODE GEN] - Reverting readOnly for two fields#3632
shahabhijeet merged 23 commits intoAzure:psSdkJson6from
ro-joowan:psSdkJson6

Conversation

@ro-joowan
Copy link
Copy Markdown
Contributor

@ro-joowan ro-joowan commented Aug 28, 2017 •
edited
Loading

  • Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8

  • The only real change is in this file: USqlJobProperties.cs

  • Question: I know that for the Swagger repo, the PRs should be based off of the fork/main branch and not from a separate branch (ro-joowan/psSdkJson6 in this case). Is this also the case for this repo? I ask because all my previous commits show up in every PR.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

ro-joowan and others added 22 commits July 24, 2017 15:23
@ro-joowan
Code gen for ADLA
853090a 
* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit is for ADLA
@ro-joowan
Code gen for ADLS
8a72cc4 
* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit for ADLS
@ro-joowan
Code gen for ADLS (part 2)
d0429b1 
* I missed this file!
@ro-joowan
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…
d97f093 
… into psSdkJson6
@ro-joowan
Code gen for ADL (part 3)
0bbe518 
* Updating to the correct commit number:
Azure/azure-rest-api-specs#1452
@matthchr @ro-joowan
Update Azure Batch to 5.1.0 (Azure#3513)
a01781f
@shahabhijeet @ro-joowan
Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519)
3793362
@Monicalyy @ro-joowan
Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482)
9efe32f 
* Do hydra to swagger specs migration for azure-sdk-for-net

* Fix build failed problem

* update the assemblyinfo file with the updated version 2.6.0

* Revert "update the assemblyinfo file with the updated version 2.6.0"

This reverts commit a33beb0.

* Updata the AssemblyFileVersion to 2.6.0.0

* revert package version

* Make project files concise.

* Add Provider test case

* update the pr with new tests with session records

* remove extra code
@matthchr @ro-joowan
Fix Batch changelog references (Azure#3517)
caba128
@ro-joowan
Merge branch 'psSdkJson6' into psSdkJson6
528d017
@ro-joowan
Fixing changelog.md
2b8907f
@ro-joowan
Fixing up changelog.md
c4593fb
@ro-joowan
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…
ddb1ea6 
… into psSdkJson6
@ro-joowan
[DataLake Analytics] Fixing changelog.md
ee186ba 
More descriptive and fixing indent issue that was not addressed in the previous commit
@ro-joowan
[DataLake Store] Fixing changelog.md
75f6a49 
More descriptive and fixing indent issue not addressed in a previous commit
@ro-joowan
[DataLake Analytics] Fixing changelog.md
deb131f 
Adding an important note about retrieving a list of jobs and accounts
@ro-joowan
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…
398f5b5 
… into psSdkJson6
@ro-joowan
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…
7c8a514 
… into psSdkJson6
@ro-joowan
Revising custom Job Exists method
7338779 
* Ran into two regressions in JobOperationTests.cs
* The custom Job Exists method is expecting a non-empty response body to
validate non-existence.  After speaking with a team member who
implemented the service, I can no longer rely on this.  Thus, I am
removing the logic that checks for a non-empty response body.
* Commenting out the test case for listing Jobs with a select parameter.
This is currently being fixed.
@ro-joowan
Adding a TODO comment
5eec416 
* Adding this as a reminder to re-enable the test
@ro-joowan
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…
b047658 
… into psSdkJson6
@ro-joowan
[CODE GEN] - Reverting readOnly for two fields
d45f70b 
* Code gen based on this very descriptive PR:
Azure/azure-rest-api-specs@e33ebf8
@msftclas
Copy link
Copy Markdown

msftclas commented Aug 28, 2017

@ro-joowan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ro-joowan ro-joowan closed this Aug 28, 2017
@ro-joowan
Copy link
Copy Markdown
Contributor Author

ro-joowan commented Aug 28, 2017 •
edited
Loading

I forgot to update the versions! Doing that now and will resubmit

@ro-joowan ro-joowan reopened this Aug 28, 2017
@msftclas
Copy link
Copy Markdown

msftclas commented Aug 28, 2017

@ro-joowan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@shawns1
Copy link
Copy Markdown

shawns1 commented Aug 28, 2017

@azuresdkci test this please

1 similar comment
@shawns1
Copy link
Copy Markdown

shawns1 commented Aug 28, 2017

@azuresdkci test this please

@shahabhijeet shahabhijeet merged commit 0175b27 into Azure:psSdkJson6 Aug 29, 2017
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
@ro-joowan @JasonYang-MSFT
[CODE GEN] - Reverting readOnly for two fields (Azure#3632)
cf1855b 
* Code gen for ADLA

* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit is for ADLA

* Code gen for ADLS

* This change is mapped to this PR:
Azure/azure-rest-api-specs#1429

* This commit for ADLS

* Code gen for ADLS (part 2)

* I missed this file!

* Code gen for ADL (part 3)

* Updating to the correct commit number:
Azure/azure-rest-api-specs#1452

* Update Azure Batch to 5.1.0 (Azure#3513)

* Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519)

* Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482)

* Do hydra to swagger specs migration for azure-sdk-for-net

* Fix build failed problem

* update the assemblyinfo file with the updated version 2.6.0

* Revert "update the assemblyinfo file with the updated version 2.6.0"

This reverts commit a33beb0.

* Updata the AssemblyFileVersion to 2.6.0.0

* revert package version

* Make project files concise.

* Add Provider test case

* update the pr with new tests with session records

* remove extra code

* Fix Batch changelog references (Azure#3517)

* Fixing changelog.md

* Fixing up changelog.md

* [DataLake Analytics] Fixing changelog.md

More descriptive and fixing indent issue that was not addressed in the previous commit

* [DataLake Store] Fixing changelog.md

More descriptive and fixing indent issue not addressed in a previous commit

* [DataLake Analytics] Fixing changelog.md

Adding an important note about retrieving a list of jobs and accounts

* Revising custom Job Exists method

* Ran into two regressions in JobOperationTests.cs
* The custom Job Exists method is expecting a non-empty response body to
validate non-existence.  After speaking with a team member who
implemented the service, I can no longer rely on this.  Thus, I am
removing the logic that checks for a non-empty response body.
* Commenting out the test case for listing Jobs with a select parameter.
This is currently being fixed.

* Adding a TODO comment

* Adding this as a reminder to re-enable the test

* [CODE GEN] - Reverting readOnly for two fields

* Code gen based on this very descriptive PR:
Azure/azure-rest-api-specs@e33ebf8

* [CODE GEN] - Updating the version (3.1.0 to 3.1.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ro-joowan @msftclas @shawns1 @shahabhijeet @matthchr @Monicalyy