Devcenter dataplane SDK v2023-04-01, integration tests, and samples#36245
Merged
ShivangiReja merged 66 commits intomainfrom Sep 23, 2023
Merged
Devcenter dataplane SDK v2023-04-01, integration tests, and samples#36245ShivangiReja merged 66 commits intomainfrom
ShivangiReja merged 66 commits intomainfrom
Conversation
* Add session records * Fix build errors in samples * Update test project file * Add devbox client tests * Add devcenter client tests * Add env client tests (incomplete) * Add devcenter admin permissions to the bicep config * Remove old devbox tests * Update env tests + session recordings * Environments tests + session records * Remove stale session records * Update env client tests and records * Update env session records * Update dev-center tests * Update session records + tests * Update env session records * Update dev center session records * Update env tests + session records * Fix typo * Update samples * Update dev-box client session records * Add pool schedule to the bicep script * Fix test naming * Fix naming
olegoid
requested review from
KrzysztofCwalina,
ShivangiReja,
chrissmiller,
mharlan,
sebrenna and
tg-msft
as code owners
olegoid
changed the base branch from
main
to
dev/sebrenna/devcenter-dataplane-2023-04-01-preview
olegoid
requested review from
ArcturusZhang,
ArthurMa1978,
RoyHerrod,
Yao725,
archerzz,
arifibrahim4,
benbp,
fengzhou-msft,
hallipr,
m-nash,
markcowl and
weshaggard
as code owners
Contributor
|
other than small nits and a couple of follow up questions, changes look good to me. @ShivangiReja let us know if you have any other comments. |
pallavit
approved these changes
Sep 21, 2023
…tps://github.com/Azure/azure-sdk-for-net into dev/olegoid/devcenter-dataplane-2023-04-01-tests
ShivangiReja
approved these changes
Sep 22, 2023
Member
|
/azp run net - devcenter - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ShivangiReja
requested changes
Sep 22, 2023
Contributor
Author
|
/azp run net - devcenter - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run net - devcenter - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run net - devcenter - tests |
ShivangiReja
approved these changes
Sep 23, 2023
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
In the case of PRs, we run tests in playback mode; live tests are not executed on PRs. We run live tests for the nightly and weekly pipeline. If running all tests live takes 3-4 hours total, that's fine. For example, you can see the nightly pipeline for Search here, which typically takes approximately 6 hours to complete. Could you please consider running the tests in live mode for this PR, or alternatively, could you create an issue to track this work and enable it in future PRs? |
Contributor
Author
|
Filed an issue that requires our team to enable live tests for the SDK: |
ShivangiReja
deleted the
dev/olegoid/devcenter-dataplane-2023-04-01-tests
branch
yaotongms
pushed a commit
to yaotongms/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2023
…zure#36245) * updating generated code
38 tasks
matthohn-msft
pushed a commit
to matthohn-msft/azure-sdk-for-net
that referenced
this pull request
Oct 27, 2023
…zure#36245) * updating generated code
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
Pipeline runs
Dry runs on the release pipeline:
https://dev.azure.com/azure-sdk/internal/_build?definitionId=5622&_a=summary
List of tests
DevBox
DevCenter
Environments
Also updated samples.