Skip to content

Upgrade Container App to 2022-11-01-preview#36173

Merged
live1206 merged 9 commits intoAzure:mainfrom
Juliehzl:user/zuh/2022-11-01-preview
May 15, 2023
Merged

Upgrade Container App to 2022-11-01-preview#36173
live1206 merged 9 commits intoAzure:mainfrom
Juliehzl:user/zuh/2022-11-01-preview

Conversation

@Juliehzl
Copy link
Copy Markdown
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels May 10, 2023
@github-actions
Copy link
Copy Markdown

Thank you for your contribution @Juliehzl! We will review the pull request and get back to you soon.

@live1206
Copy link
Copy Markdown
Member

@Juliehzl Please merge the latest main to your branch and re-generate the SDK

@Juliehzl Juliehzl force-pushed the user/zuh/2022-11-01-preview branch from f4287da to ffb48ef Compare May 10, 2023 09:06
@live1206
Copy link
Copy Markdown
Member

Generated code is not up to date.
You may need to rebase on the latest main,
run 'eng\scripts\Update-Snippets.ps1' if you modified sample snippets or other *.md files (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#updating-sample-snippets),
run 'eng\scripts\Export-API.ps1' if you changed public APIs (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#public-api-additions).
run 'dotnet build /t:GenerateCode' to update the generated code.
run 'dotnet build /t:GenerateTests' to update the generated test code.
To reproduce this error locally, run 'eng\scripts\CodeChecks.ps1 -ServiceDirectory containerapps'.

@Juliehzl

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.AppContainers

@Juliehzl Juliehzl force-pushed the user/zuh/2022-11-01-preview branch from 6232dba to 6077eea Compare May 11, 2023 08:13
@live1206
Copy link
Copy Markdown
Member

@Juliehzl Please check the comments in APIView: #36173 (comment)
And also, please update the change log for the new version.

@live1206
Copy link
Copy Markdown
Member

/azp run net - resourcemanager - mgmt - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@live1206
Copy link
Copy Markdown
Member

/azp run net - resourcemanager - mgmt - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@live1206 live1206 merged commit 04dba6a into Azure:main May 15, 2023
@ArthurMa1978 ArthurMa1978 added Mgmt This issue is related to a management package. breaking-change labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants