Add Azure container instance net SDK#3615
Add Azure container instance net SDK#3615shahabhijeet merged 3 commits intoAzure:psSdkJson6from yolocs:aci_sdk
Conversation
|
@yolo3301, |
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- When xunit cannot detect tests, uncomment the following dependencies --> |
| [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Container Instance.")] | ||
|
|
||
| [assembly: AssemblyVersion("1.0.0.0")] | ||
| [assembly: AssemblyFileVersion("1.2.0.0")] |
There was a problem hiding this comment.
@yolo3301 have consistent versions between nuget version as well as AssemblyFile Version.
src/SDKs/dirs.proj
Outdated
| <ProjectToBuild Include="$(MSBuildThisFileDirectory)Cdn\Management.Cdn\Microsoft.Azure.Management.Cdn.csproj" /> | ||
| <ProjectToBuild Include="$(MSBuildThisFileDirectory)CognitiveServices\Management.CognitiveServices\Microsoft.Azure.Management.CognitiveServices.csproj" /> | ||
| <ProjectToBuild Include="$(MSBuildThisFileDirectory)Compute\Management.Compute\Microsoft.Azure.Management.Compute.csproj" /> | ||
| <ProjectToBuild Include="$(MSBuildThisFileDirectory)ContainerInstance\Management.ContainerInstance\Microsoft.Azure.Management.ContainerInstance.csproj" /> |
There was a problem hiding this comment.
@yolo3301 dirs.proj is no longer used, you can revert this change.
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
@yolo3301 please provide detailed description about this PR.
If this is your first version, please specify it else describe the changes going in this version.
|
awesome, thank you! |
|
@shahabhijeet Thanks for reviewing. All comments have been addressed. |
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
@yolo3301 this is your first time, are you sure you want to go 1.0.0 or you rather go 1.0.0-preview
If so, please mark as that version in csproj file and not AssemblyInfo.cs
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netcoreapp1.1</TargetFrameworks> | ||
| <StartupObject></StartupObject> |
| // Setting ComVisible to false makes the types in this assembly not visible | ||
| // to COM components. If you need to access a type in this assembly from | ||
| // COM, set the ComVisible attribute to true on that type. | ||
| [assembly: ComVisible(false)] |
There was a problem hiding this comment.
nit:
@yolo3301 you made this assembly COM visible false, but then providing typelib GUID
Please consider removing this.
| <AssemblyName>Microsoft.Azure.Management.ContainerInstance</AssemblyName> | ||
| <PackageId>Microsoft.Azure.Management.ContainerInstance</PackageId> | ||
| <PackageTags>Microsoft Azure Container Instance Management;Container Instance;REST HTTP client;azureofficial;windowsazureofficial;netcore451511</PackageTags> | ||
| <PackageIconUrl>http://go.microsoft.com/fwlink/?LinkID=288890</PackageIconUrl> |
There was a problem hiding this comment.
@yolo3301 please remove this tag, as it's centrally controlled.
|
@shahabhijeet I do want to go with 1.0.0-preview. So I removed the versions in AssemblyInfo.cs. |
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
as soon as CI passes, this is good to go
|
@shahabhijeet The other check failed. However, I don't have permission to check what's wrong there. Could you help? |
* Add Azure container instance net SDK * Revert unnecessary changes and make version consistent * remove some unnecessary metadata
4 participants
Description
This is the first version of Azure container instance .net SDK.
The API spec has already been reviewed and merged. See below.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.