Skip to content

Api2017 08 01- Regenerating SDK to fix Network Swagger issue: both LRO and Paging at the same time#3594

Merged
shahabhijeet merged 4 commits intoAzure:psSdkJson6from
gmainar:API2017-08-01
Aug 16, 2017
Merged

Api2017 08 01- Regenerating SDK to fix Network Swagger issue: both LRO and Paging at the same time#3594
shahabhijeet merged 4 commits intoAzure:psSdkJson6from
gmainar:API2017-08-01

Conversation

@gmainar
Copy link
Copy Markdown
Contributor

@gmainar gmainar commented Aug 16, 2017

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@msftclas
Copy link
Copy Markdown

msftclas commented Aug 16, 2017

@gmainar,
Thanks for your contribution. It looks like you are a Microsoft vendor. To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

The agreement will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@gmainar gmainar changed the title Api2017 08 01 Api2017 08 01- Regenerating SDK to fix Network Swagger issue: both LRO and Paging at the same time Aug 16, 2017
@shahabhijeet
Copy link
Copy Markdown
Contributor

shahabhijeet commented Aug 16, 2017

@azuresdkci test this please

1 similar comment
@shawns1
Copy link
Copy Markdown

shawns1 commented Aug 16, 2017

@azuresdkci test this please

@shahabhijeet shahabhijeet merged commit 5a8b476 into Azure:psSdkJson6 Aug 16, 2017
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
@gmainar @JasonYang-MSFT
Api2017 08 01- Regenerating SDK to fix Network Swagger issue: both LR…
4cf3a5c 
…O and Paging at the same time (Azure#3594)

* SDK generated for networking version 2017-08-01

* Disabling network tests

* regenerated SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DeepakRajendranMsft DeepakRajendranMsft DeepakRajendranMsft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gmainar @msftclas @shahabhijeet @shawns1 @DeepakRajendranMsft