Skip to content

Servicebus: Removed the maxLength for entity names#3588

Merged
shahabhijeet merged 3 commits intoAzure:psSdkJson6from
v-Ajnava:SB_maxlengthRemoval
Aug 16, 2017
Merged

Servicebus: Removed the maxLength for entity names#3588
shahabhijeet merged 3 commits intoAzure:psSdkJson6from
v-Ajnava:SB_maxlengthRemoval

Conversation

@v-Ajnava
Copy link
Copy Markdown

Description

Removed the MaxLength for entity names.
swagger PR Link : Azure/azure-rest-api-specs#1527

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

[assembly: AssemblyDescription("Provides Microsoft Azure ServiceBus management functions for managing the Microsoft Azure ServiceBus service.")]

[assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyVersion("1.0.1.0")]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-Ajnava usually you increase AssemblyFileVersion, in this case increase AssemblyFileVersion and no need to increase AssemblyVersion

@shahabhijeet shahabhijeet merged commit 1fcf77a into Azure:psSdkJson6 Aug 16, 2017
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
* Removed the maxLength for entity names

* Added test for maxlength removal

* updated the AssemblyFileVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants