Relay : Removed the maxLength for entity names#3587
Merged
shahabhijeet merged 3 commits intoAzure:psSdkJson6from Aug 16, 2017
Merged
Relay : Removed the maxLength for entity names#3587shahabhijeet merged 3 commits intoAzure:psSdkJson6from
shahabhijeet merged 3 commits intoAzure:psSdkJson6from
Conversation
Contributor
|
@v-Ajnava no tests? |
shahabhijeet
suggested changes
Aug 16, 2017
Contributor
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
Once the AssemblyFileVersion is updated, this PR is good to go
| [assembly: AssemblyDescription("Provides Microsoft Azure Relay management functions for managing the Microsoft Azure Relay service")] | ||
|
|
||
| [assembly: AssemblyVersion("2.0.0.0")] | ||
| [assembly: AssemblyVersion("2.0.1.0")] |
Contributor
There was a problem hiding this comment.
@v-Ajnava usually you always bump up file version and only bump up AssemblyVersion when you bump up major version.
shahabhijeet
approved these changes
Aug 16, 2017
JasonYang-MSFT
pushed a commit
to JasonYang-MSFT/azure-sdk-for-net
that referenced
this pull request
Dec 8, 2017
* Removed the maxLength for entity names * added test for maxlength removal * updated the AssemblyFileVersion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed the MaxLength for entity names.
swagger PR Link : Azure/azure-rest-api-specs#1535
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.