Skip to content

Updated RecoveryServices.Backup from latest swagger spec#3566

Merged
shahabhijeet merged 3 commits intoAzure:psSdkJson6from
DheerendraRathor:psSdkJson6
Aug 16, 2017
Merged

Updated RecoveryServices.Backup from latest swagger spec#3566
shahabhijeet merged 3 commits intoAzure:psSdkJson6from
DheerendraRathor:psSdkJson6

Conversation

@DheerendraRathor
Copy link
Copy Markdown
Contributor

@DheerendraRathor DheerendraRathor commented Aug 9, 2017 •
edited
Loading

Description

  • Moved ListJobs and GetJobDetails to api version 2017-07-01
  • Bumped version to 2.1.0-preview

Spec PR: Azure/azure-rest-api-specs#1502

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@shahabhijeet
Copy link
Copy Markdown
Contributor

shahabhijeet commented Aug 10, 2017 •
edited
Loading

@DheerendraRathor add a description as to what this PR is all about.
Any information that helps in understanding what is this PR about.
If it's just API version change, mention that in the description.
Once you add the description and the PR is ready to review, remove the "needs-revision" label

@DheerendraRathor
Copy link
Copy Markdown
Contributor Author

DheerendraRathor commented Aug 10, 2017

@shahabhijeet I've updated description. Looks like I don't have permission to update labels.

@DheerendraRathor
Copy link
Copy Markdown
Contributor Author

DheerendraRathor commented Aug 13, 2017

@shahabhijeet Any update on this?

shahabhijeet
shahabhijeet suggested changes Aug 14, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you now execute generate.cmd, it creates a .txt file under _metadata directory for your RP, which will be helpful for all future regeneration of the SDK

src/SDKs/RecoveryServices.Backup/Management.RecoveryServices.Backup/Properties/AssemblyInfo.cs Outdated
@@ -8,7 +8,7 @@
[assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Recovery Services Backup Resources.")]

[assembly: AssemblyVersion("1.0.0.0")]
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DheerendraRathor bump Assemblyversion to 2.0.0.0

@DheerendraRathor
Copy link
Copy Markdown
Contributor Author

DheerendraRathor commented Aug 15, 2017

@shahabhijeet Added _metadata/recoveryservicesbackup_resource-manager.txt and updated AssemblyVersion

@DheerendraRathor
Copy link
Copy Markdown
Contributor Author

DheerendraRathor commented Aug 16, 2017

@shahabhijeet Any update on this PR?

@shahabhijeet shahabhijeet merged commit bf717a2 into Azure:psSdkJson6 Aug 16, 2017
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
@DheerendraRathor @JasonYang-MSFT
Updated RecoveryServices.Backup from latest swagger spec (Azure#3566)
a11f541 
* Updated RecoveryServices.Backup with latest swagger spec

* Updated sdk version in AssemblyInfo.cs and csproj

* Added generate.cmd metadata files and bumped AssemblyVersion to 2.0.0.0
@4way4eva 4way4eva mentioned this pull request Oct 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DheerendraRathor @shahabhijeet @msftclas