Management.Sql - Generated SQL DataSync and added test scenario's by ScottHolden · Pull Request #3558 · Azure/azure-sdk-for-net

ScottHolden · 2017-08-08T04:40:52Z

Description

Generated Management.Sql with package-2015-05-preview api spec including datasync, added SyncAgent SyncGroup SyncMember scenario's with session records.

Corresponding rest-api-spec change can be found at:
Azure/azure-rest-api-specs#1510

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

…ing datasync, added SyncAgent SyncGroup SyncMember scenario's with session records.

azuresdkci · 2017-08-08T04:40:53Z

Can one of the admins verify this patch?

azuresdkci · 2017-08-08T04:40:53Z

Can one of the admins verify this patch?

azuresdkci · 2017-08-08T04:40:53Z

Can one of the admins verify this patch?

msftclas · 2017-08-08T04:40:55Z

@ScottHolden,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

azuresdkci · 2017-08-08T04:43:06Z

Can one of the admins verify this patch?

msftclas · 2017-08-08T04:53:07Z

@ScottHolden, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

ScottHolden · 2017-08-08T04:53:18Z

I have signed the cla :)

shahabhijeet · 2017-08-08T13:14:07Z

@ScottHolden are you part of the Azure org, if not please become a part of the Azure Team by visiting
https://github.com/Azure/

jaredmoo · 2017-08-08T16:22:30Z

@fhljys ,@ferno-ms , @nathannfan fyi

jaredmoo

Looks excellent, just some minor changes requested. Thank you!

jaredmoo · 2017-08-08T16:24:10Z

src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj

    <Description>Azure SQL Management SDK library</Description>
    <AssemblyName>Microsoft.Azure.Management.Sql</AssemblyName>
-    <VersionPrefix>1.7.0-preview</VersionPrefix>
+    <VersionPrefix>1.8.0-preview</VersionPrefix>


the latest published version is 1.6.0 (see https://www.nuget.org/packages/Microsoft.Azure.Management.Sql ) so please undo this

jaredmoo · 2017-08-08T16:24:20Z

src/SDKs/SqlManagement/Management.Sql/Properties/AssemblyInfo.cs

-
-
-
+[assembly: AssemblyFileVersion("1.8.0.0")]


please undo

jaredmoo · 2017-08-08T16:28:01Z

src/SDKs/SqlManagement/Sql.Tests/SyncMemberScenarioTests.cs

+                });
+                Assert.NotNull(updateSyncMember);
+                Assert.Equal(updateSyncMemberDirection, updateSyncMember.SyncDirection);
+                Assert.NotEqual(syncMemberDirection, updateSyncMemberDirection);


can you also test empty update, e.g.

// Empty update of sync member SyncMember updateSyncMember2 = sqlClient.SyncMembers.Update(resourceGroup.Name, server.Name, testDatabaseName, syncGroupName, syncMemberName, new SyncMember());

jaredmoo · 2017-08-08T16:29:23Z

src/SDKs/SqlManagement/Sql.Tests/SyncMemberScenarioTests.cs

+                IPage<SyncMember> listSyncMembers = sqlClient.SyncMembers.ListBySyncGroup(resourceGroup.Name, server.Name, testDatabaseName, syncGroupName);
+                Assert.NotNull(listSyncMembers);
+                Assert.Equal(1, listSyncMembers.Count());
+                Assert.Equal(syncMemberName, listSyncMembers.FirstOrDefault()?.Name);


nit: already checked that there is one, so this can be listSyncMembers.Single().Name

jaredmoo · 2017-08-08T16:30:19Z

src/SDKs/SqlManagement/Sql.Tests/SyncGroupScenarioTests.cs

+                    Interval = interval2
+                });
+                Assert.NotNull(updateSyncGroup);
+                Assert.Equal(interval2, updateSyncGroup.Interval);


Can you please test empty update, i..e.

SyncGroup updateSyncGroup = sqlClient.SyncGroups.Update(resourceGroup.Name, server.Name, testDatabaseName, syncGroupName, new SyncGroup());

oops, these empty updates ideally should not fail. Not your fault though, it has to be fixed server-side. Thanks for testing!

…ed scenarios

ScottHolden · 2017-08-08T23:33:11Z

@shahabhijeet I'm not currently part of the Azure GitHub organisation, who do I need to reach out to to be added, as I couldn't see a link on https://github.com/Azure/

jaredmoo · 2017-08-09T00:17:46Z

@ScottHolden I think that this is only applicable to Microsoft employees working in the Azure organization. So my understanding is that this is not applicable to you.

shahabhijeet · 2017-08-10T02:10:03Z

@azuresdkci test this please

shahabhijeet · 2017-08-10T02:12:31Z

@ScottHolden sql tests are failing on travis.
Were you able to successfully run SQL tests locally?
Click on Details and check the failures.

shahabhijeet · 2017-08-10T02:12:47Z

@azuresdkci add to whitelist

ScottHolden · 2017-08-10T03:28:03Z

All tests were working fine locally @shahabhijeet. I was able to run in record mode and playback mode, and committed the SessionRecord with the test changes.
I'll have a look into what is happening and try and replicate locally :)

ScottHolden · 2017-08-14T00:45:28Z

Running locally gives me no errors at all, I can't seem to replicate :(

jaredmoo · 2017-08-14T04:05:21Z

It looks like the lab build merges with the target branch (azure/psSdkJson6) before running tests, and we made some incompatible test changes recently that you haven't pulled in. It should be fixed by merging from azure/psSdkJson6 and re-recording the tests. You will need to add a few new properties to your test environment connection string, e.g. DefaultLocationId=japaneast;DefaultLocation=Japan East.

Backmerge

ScottHolden · 2017-08-14T12:31:48Z

Thanks @jaredmoo ! That did the trick :)
Should be fine to merge now :)

shahabhijeet

@jaredmoo I assume you will be updating the AssemblyInfo to reflect the next release version.

jaredmoo · 2017-08-14T20:12:00Z

Awesome! Yes AssemblyInfo is handled. Thx

…ure#3558) * Generated Management.Sql with package-2015-05-preview api spec including datasync, added SyncAgent SyncGroup SyncMember scenario's with session records. * Reverted version to 1.7.0, made minor changes to scenarios, re-recorded scenarios * Regenerated sql management client now rest api specs have been merged. * Re-recorded DataSync test scenarios

Generated Management.Sql with package-2015-05-preview api spec includ…

cdf158b

…ing datasync, added SyncAgent SyncGroup SyncMember scenario's with session records.

msftclas added the cla-required label Aug 8, 2017

ScottHolden mentioned this pull request Aug 8, 2017

Microsoft.Sql - Added data sync to package-2015-05-preview Azure/azure-rest-api-specs#1510

Merged

10 tasks

msftclas added cla-signed and removed cla-required labels Aug 8, 2017

jaredmoo suggested changes Aug 8, 2017

View reviewed changes

Reverted version to 1.7.0, made minor changes to scenarios, re-record…

3971871

…ed scenarios

jaredmoo approved these changes Aug 9, 2017

View reviewed changes

shahabhijeet added the needs-revision label Aug 10, 2017

Regenerated sql management client now rest api specs have been merged.

88b6f06

ScottHolden added 2 commits August 14, 2017 18:13

Merge pull request #1 from Azure/psSdkJson6

97ae5b9

Backmerge

Re-recorded DataSync test scenarios

150d2cf

shahabhijeet approved these changes Aug 14, 2017

View reviewed changes

shahabhijeet merged commit 5b5bbd8 into Azure:psSdkJson6 Aug 14, 2017




		[assembly: AssemblyFileVersion("1.8.0.0")] No newline at end of file

Conversation

ScottHolden commented Aug 8, 2017

Description

Uh oh!

azuresdkci commented Aug 8, 2017

Uh oh!

azuresdkci commented Aug 8, 2017

Uh oh!

azuresdkci commented Aug 8, 2017

Uh oh!

msftclas commented Aug 8, 2017

Uh oh!

azuresdkci commented Aug 8, 2017

Uh oh!

msftclas commented Aug 8, 2017

Uh oh!

ScottHolden commented Aug 8, 2017

Uh oh!

shahabhijeet commented Aug 8, 2017

Uh oh!

jaredmoo commented Aug 8, 2017

Uh oh!

jaredmoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ScottHolden commented Aug 8, 2017

Uh oh!

jaredmoo commented Aug 9, 2017

Uh oh!

shahabhijeet commented Aug 10, 2017

Uh oh!

shahabhijeet commented Aug 10, 2017

Uh oh!

shahabhijeet commented Aug 10, 2017

Uh oh!

ScottHolden commented Aug 10, 2017

Uh oh!

ScottHolden commented Aug 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaredmoo commented Aug 14, 2017

Uh oh!

ScottHolden commented Aug 14, 2017

Uh oh!

shahabhijeet left a comment

Choose a reason for hiding this comment

Uh oh!

jaredmoo commented Aug 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ScottHolden commented Aug 14, 2017 •

edited

Loading