first version of C# apim spec on autorest#3544
first version of C# apim spec on autorest#3544shahabhijeet merged 2 commits intoAzure:psSdkJson6from solankisamir:psSdkJson6
Conversation
|
@solankisamir, |
solankisamir
requested review from
KedarJoshi and
cormacpayne
and removed request for
olydis
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
@solankisamir can you provide link to the Swagger PR that was merged.
| <PropertyGroup> | ||
| <PackageId>ApiManagement.Tests</PackageId> | ||
| <Description>ApiManagement.Tests Class Library</Description> | ||
| <VersionPrefix>1.0.0-preview</VersionPrefix> |
There was a problem hiding this comment.
@solankisamir make versionPrefix as version and remove version tag from below property group.
| <Folder Include="Resources\" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <None Update="Resources\SwaggerPetStoreV2.json"> |
There was a problem hiding this comment.
@solankisamir remove exclusive enumeration of files, rather do exactly what have been done in the above itemgroup for all *.json files under SessionRecords.
| { | ||
| HttpMockServer.Variables[TestCertificateKey] = base64EncodedTestCertificateData; | ||
| } | ||
| this.testCertificatePassword = testEnv.ConnectionString.KeyValuePairs.GetValueUsingCaseInsensitiveKey(TestCertificatePasswordKey); |
There was a problem hiding this comment.
@solankisamir Can you not use GetValueusingCaseInsenitiveKey API, I am planning to deprecate that function as KeyVaulePair Dictionary has been implemented to be case Insensitve.
| } | ||
| else if (HttpMockServer.Mode == HttpRecorderMode.Playback) | ||
| { | ||
| this.tenantId = testEnv.Tenant; |
There was a problem hiding this comment.
@solankisamir maybe it's not clear to me, but why you need to do all this initialization during playback?
There was a problem hiding this comment.
remove some extra variables. I require some initialization during playback, as some of the tests can only be executed on an active service. Service Activation takes 40 minutes, hence I use this as a place to provide active service details and proceed with additional validation.
| { | ||
| public static class Extensions | ||
| { | ||
| public static bool DictionaryEqual<TKey, TValue>(this IDictionary<TKey, TValue> first, IDictionary<TKey, TValue> second) |
There was a problem hiding this comment.
@solankisamir
nit: Can you not use Linq extension methods first.Except(second) or better use Linq to do the comparison.
I assume you only want to compare keys and not their values, in that case you can still do that using the above
| <TargetFrameworks>net452;netstandard1.4</TargetFrameworks> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Folder Include="Customization\Models\" /> |
There was a problem hiding this comment.
@solankisamir you don't need to include any folders. Project system will include it. This is not needed
|
@solankisamir as long as Kedar or someone from your team approves, this is good to merge |
|
@shahabhijeet can you take a look? |
|
@azuresdkci test this please |
|
#sign-off |
4 participants
Description
This is the first version of the API Management C# client library based on AutoRest spec.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.