Alpha support to Elliptic Curve keys to JsonWebKey classes#3539
Alpha support to Elliptic Curve keys to JsonWebKey classes#3539msfcolombo wants to merge 5 commits intoAzure:psSdkJson6from
Conversation
|
@msfcolombo, |
|
@azuresdkci test this please |
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
@msfcolombo please have a signoff from include Rich Randal or Dragos
| var ecdsa_jwk = jwk.ToECDsa(usePrivateKey); | ||
|
|
||
| Assert.Equal(ecdsa_jwk.KeySize, ecdsa.KeySize); | ||
| #if NET452 |
There was a problem hiding this comment.
@msfcolombo please use #FullNetFx moniker for Full Desktop version of .NET
| @@ -1,11 +1,11 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.props'))" /> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.reference.props'))" /> | |||
There was a problem hiding this comment.
@msfcolombo any reason to start taking dependency on common clientRuntime binaries. Only management plane has taken dependency on them?
There was a problem hiding this comment.
We intend to provide WebKey to more environments. It's a low-level component. The use of AzSdk.reference.props is to insure compatibility and avoid proj code duplication.
|
@shahabhijeet I did the change you requested, and commented over usage of AzSdk.reference.props. I got sign-off from Hervey and Dragos. Is there something else before merging? |
|
@azuresdkci test this please |
|
@shahabhijeet All requested changes were performed. Thanks for the push into keeping a low number of dependencies, and let us know if there is anything preventing merge. |
|
Changes here are now included on #3577. |
6 participants
Alpha support to Elliptic Curve keys to JsonWebKey classes
This PR adds alpha support for Elliptic Curve keys the Microsoft.Azure.KeyVault.WebKey namespace. This is intended to allow customers and partners accessing the Elliptic Curve features of Azure Key Vault in preview mode.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.