Skip to content

[WebJobs.Extensions.Queues/[WebJobs.Extensions.Blobs] Scaler APIs#35358

Merged
amnguye merged 12 commits intoAzure:mainfrom
alrod:alrod/storage-sc
Jun 9, 2023
Merged

[WebJobs.Extensions.Queues/[WebJobs.Extensions.Blobs] Scaler APIs#35358
amnguye merged 12 commits intoAzure:mainfrom
alrod:alrod/storage-sc

Conversation

@alrod
Copy link
Copy Markdown
Member

@alrod alrod commented Apr 4, 2023

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Apr 4, 2023
@alrod alrod changed the title [WebJobsExtensionsQueue/WebJobsExtensionsBlob] Scaler APIs [WebJobs.Extensions.Queue/WebJobs.Extensions.Blob] Scaler APIs Apr 4, 2023
@alrod alrod force-pushed the alrod/storage-sc branch from 6533d75 to e232dcc Compare April 6, 2023 23:56
@alrod alrod changed the title [WebJobs.Extensions.Queue/WebJobs.Extensions.Blob] Scaler APIs [WebJobs.Extensions.Queue] Scaler APIs Apr 6, 2023
@alrod alrod changed the title [WebJobs.Extensions.Queue] Scaler APIs [WebJobs.Extensions.Queues/[WebJobs.Extensions.Blobs] Scaler APIs Apr 7, 2023
@alrod alrod force-pushed the alrod/storage-sc branch from e232dcc to d2c1fac Compare April 7, 2023 18:52
@alrod alrod force-pushed the alrod/storage-sc branch from d2c1fac to 70af0f2 Compare April 18, 2023 21:40
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Apr 18, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Azure.WebJobs.Extensions.Storage.Blobs
Microsoft.Azure.WebJobs.Extensions.Storage.Queues

@alrod alrod requested a review from amnguye April 24, 2023 23:50
@amnguye
Copy link
Copy Markdown
Member

amnguye commented May 31, 2023

/azp run net - storage - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@amnguye
Copy link
Copy Markdown
Member

amnguye commented Jun 1, 2023

@alrod There's consistent live test failures, can this get resolved before the PR is merged?
BlobScaleHostEndToEndTest
ScaleHostEndToEndTest(False)
ScaleHostEndToEndTest(True)

They all have the same exception thrown
System.ApplicationException : Condition not reached within timeout.

@alrod alrod requested a review from amnguye June 2, 2023 20:35
@amnguye
Copy link
Copy Markdown
Member

amnguye commented Jun 2, 2023

/azp run net - storage - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@amnguye
Copy link
Copy Markdown
Member

amnguye commented Jun 2, 2023

/azp run net - storage - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Member

@amnguye amnguye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - So long as the webjobs related tests pass live

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@alrod
Copy link
Copy Markdown
Member Author

alrod commented Jun 7, 2023

/azp run net - storage - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@alrod
Copy link
Copy Markdown
Member Author

alrod commented Jun 8, 2023

/azp run net - storage - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@alrod
Copy link
Copy Markdown
Member Author

alrod commented Jun 8, 2023

/azp run net - storage - tests

@alrod alrod closed this Jun 8, 2023
@alrod alrod reopened this Jun 8, 2023
@alrod
Copy link
Copy Markdown
Member Author

alrod commented Jun 8, 2023

/azp run net - storage - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@alrod
Copy link
Copy Markdown
Member Author

alrod commented Jun 9, 2023

/azp run net - storage - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@amnguye
Copy link
Copy Markdown
Member

amnguye commented Jun 9, 2023

/check-enforcer override

@amnguye amnguye merged commit 1ba51a4 into Azure:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants