Adding ActivityLogAlerts and ActionGroups API calls, PATH operations, and the corresponding unit tests by gucalder · Pull Request #3514 · Azure/azure-sdk-for-net

gucalder · 2017-07-25T15:51:41Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

…branch

…into vs17Dev

… and using the previous API again

…nitor composite file

…package names

…into vs17Dev

…ect file accordingly.

…into vs17Dev

…ure#3236) * Renaming Management.Search to Microsoft.Azure.Management.Search The package and assembly names were accidentally changed during the VS2017 migration. This fixes it. * Search SDK: Updating Build-SearchPackages script

…responding tests

…into vs17Dev

…into activityAndAction

shahabhijeet · 2017-07-26T17:38:56Z

src/SDKs/Monitor/Management.Monitor/Microsoft.Azure.Management.Monitor.csproj

  <PropertyGroup>
    <Description>Microsoft Azure Monitor Library</Description>
-    <VersionPrefix>0.16.0-preview</VersionPrefix>
+    <VersionPrefix>0.16.1-preview</VersionPrefix>


@gucalder you have redundant tags, please remove versionPrefix and move the Version under the top PropertyGroup

shahabhijeet · 2017-07-26T17:39:41Z

src/SDKs/Monitor/Monitor.Tests/Monitor.Tests.csproj

    <Description>Monitor.Tests Class library</Description>
    <PackageId>Monitor.Tests</PackageId>
    <VersionPrefix>1.0.0-preview</VersionPrefix>
+    <TargetFrameworks>net452</TargetFrameworks>


@gucalder any reason you want your tests to be targeting .NET 452?
If this was a mistake please remove

This is odd, as soon as I remove .Net 452 from this project file, VS builds, but it does not detect any unit test.

BTW: I can only build from VS 2017, not from the command line, nor from the root of the repo.
Is that expected?
Do I need to use any special argument to build from the command line?

shahabhijeet · 2017-07-26T17:41:06Z

src/SDKs/Search/Management/Search.Management.Tests/Search.Management.Tests.csproj

  <ItemGroup>
    <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.5.0-preview" />
-    <ProjectReference Include="..\Management.Search\Management.Search.csproj" />
+    <ProjectReference Include="..\Management.Search\Microsoft.Azure.Management.Search.csproj" />


@gucalder do you have any changes for the Search management SDK? Or was this is a mistake.

Definitely a mistake. I do not remember changing this file.

In fact I do not know how or why this change is linked to me.
I am going to try merging the Azure/vs17Dev into my branch to see if that helps... I did not touch that file.

@gucalder vs17Dev is not the current dev branch. psSdkJson6 is the current dev branch.

@gucalder Please revert Search-related changes

… into activityAndAction

brjohnstmsft · 2017-07-27T20:10:58Z

src/SDKs/Search/Management/Search.Management.Tests/Search.Management.Tests.csproj

  <ItemGroup>
    <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.5.0-preview" />
-    <ProjectReference Include="..\Management.Search\Management.Search.csproj" />
+    <ProjectReference Include="..\Management.Search\Microsoft.Azure.Management.Search.csproj" />


@gucalder Please revert Search-related changes

gucalder and others added 25 commits April 17, 2017 16:45

Merging AutoRest branch changes to issue a pull request from vs17Dev …

0559fe1

…branch

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

4e31b86

…into vs17Dev

Fixing version of Newtonsoft.Json

c5c1893

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

e70107e

…into vs17Dev

Adding some unit tests and making sure the Tests project works.

a7c7afa

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

ca7071b

…into vs17Dev

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

b3d3060

…into vs17Dev

Adding some items to the proj file

43f1ddc

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

9a86955

…into vs17Dev

Commenting imports in the project file

83e227b

Changing class namespace of the generated code

7c5fac0

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

38ce61e

…into vs17Dev

Changing namespace and assembly name for compliance

bccf4ae

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

679cbc6

…into vs17Dev

Leaving the Swagger spec for DiagnosticSettings out of the generation…

ec98570

… and using the previous API again

Updating the generate.cmd command to the latest commit for the arm-mo…

2d791da

…nitor composite file

Making the default class namespace consistent with the dll and nuget …

1e1c3f3

…package names

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

6832139

…into vs17Dev

Removing unused test files (DiagnosticSettings) and changing the proj…

84b3cf9

…ect file accordingly.

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

8551b5a

…into vs17Dev

Adding ActivityLogAlerts, ActionGroups, PATCH operations, and the cor…

ecd189a

…responding tests

Merge branch 'vs17Dev' of https://github.com/Azure/azure-sdk-for-net …

c2e2613

…into vs17Dev

Merge branch 'vs17Dev' of https://github.com/AuxMon/azure-sdk-for-net …

c6a1491

…into activityAndAction

Making the assembly version consistent

7eae955

msftclas added the cla-not-required label Jul 25, 2017

shahabhijeet requested a review from brjohnstmsft July 26, 2017 17:41

shahabhijeet suggested changes Jul 26, 2017

View reviewed changes

shahabhijeet added the needs-revision label Jul 26, 2017

Minor changes from PR feedback.

4e5b30e

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

99af050

… into activityAndAction

brjohnstmsft suggested changes Jul 27, 2017

View reviewed changes

gucalder closed this Jul 27, 2017

gucalder mentioned this pull request Jul 27, 2017

Adding ActivityLogAlerts and ActionGroups API calls, PATCH operations, and the corresponding unit tests #3520

Merged

8 tasks

gucalder deleted the activityAndAction branch August 23, 2017 17:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding ActivityLogAlerts and ActionGroups API calls, PATH operations, and the corresponding unit tests#3514

Adding ActivityLogAlerts and ActionGroups API calls, PATH operations, and the corresponding unit tests#3514
gucalder wants to merge 27 commits intoAzure:psSdkJson6from
AuxMon:activityAndAction

gucalder commented Jul 25, 2017

Uh oh!

shahabhijeet Jul 26, 2017

Uh oh!

shahabhijeet Jul 26, 2017

Uh oh!

gucalder Jul 26, 2017

Uh oh!

gucalder Jul 26, 2017

Uh oh!

shahabhijeet Jul 26, 2017

Uh oh!

gucalder Jul 26, 2017

Uh oh!

gucalder Jul 26, 2017

Uh oh!

shahabhijeet Jul 27, 2017

Uh oh!

brjohnstmsft Jul 27, 2017

Uh oh!

brjohnstmsft Jul 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gucalder commented Jul 25, 2017

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants