BREAKING CHANGE: Adl object refactor#3512
Merged
shahabhijeet merged 12 commits intoAzure:psSdkJson6from Aug 4, 2017
Merged
Conversation
* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA
* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS
* I missed this file!
|
@ro-joowan, |
* Updating to the correct commit number: Azure/azure-rest-api-specs#1452
Contributor
|
@cormacpayne the check boxes are getting cleared every time the page is refreshed. I promise @ro-joowan checked all the boxes :) |
begoldsm
approved these changes
Jul 25, 2017
Contributor
begoldsm
left a comment
begoldsm
left a comment
There was a problem hiding this comment.
I sat with Joo Wan while he made these changes and I approve this message 
* Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code
Contributor
|
@azuresdkci test this please |
Contributor
|
@ro-joowan test this please |
ro-joowan
added a commit
to ro-joowan/azure-powershell
that referenced
this pull request
Sep 14, 2017
* Based on this Swagger PR: Azure/azure-rest-api-specs#1452 * Based on this .NET PR: Azure/azure-sdk-for-net#3512 * Besides code refactoring for type changes, the only real change is updating adapting to how Job submission/build works in src\ResourceManager\DataLakeAnalytics\Commands.DataLakeAnalytics\Commands\SubmitAzureRmDataLakeAnalyticsJob.cs * For the deleted PS<some properties object>.cs files, it is because via Swagger these properties have been flattened. E.g. in src\ResourceManager\DataLakeAnalytics\Commands.DataLakeAnalytics\Models\PSDataLakeStoreAccountInfo.cs: [Obsolete("In a future release this object will have all 'Properties' properties flattened and the 'Properties' property will be removed. Until then, nested properies will be duplicated.")] * Updated the tests ever so slightly to make them more reliable. I also ran them live and updated the SessionRecords folder for both ADLA and ADLS
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code gen for this PR: Refactoring changes in order to match with Ben's refactoring changes azure-rest-api-specs#1452 (which is below for reference)
Refactor objects for account and for job submission
This does the following:
Create an explicit set of parameters for job submission. NOTE: Only
U-SQL is supported in this change, no hive jobs are supported at
present.
Create a "Basic" jobInformation that is returned for LIST calls
Setup inheritance for GET jobs
Create an inheritance structure for GET and LIST ADLS and ADLA
accounts.
This also follows the Basic -> Object inheritance pattern.
Fix examples and job_build
Missed some of the example changes
Missed Job_Build, which should have its own parameters object as well.
Moving accountId into the right place in the example.
Updates to include name for buildjob
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.