Add Translation Text client library#34965
Merged
joseharriaga merged 51 commits intoAzure:mainfrom Apr 6, 2023
MikeyMCZ:main
Merged
Add Translation Text client library#34965joseharriaga merged 51 commits intoAzure:mainfrom MikeyMCZ:main
joseharriaga merged 51 commits intoAzure:mainfrom
MikeyMCZ:main
Conversation
Mimat/translator
Removing Detect
Fixing BreakSentence
Mimat/documentation
* Initial work for adding tests * Sanitizing the keys * Covering all test scenarios from Sample document and Hero scenarios * Updating dynamic dictionary test case * Updated based on PR comments --------- Co-authored-by: Hamshavathi Munibyraiah (Murphy V-hmunibyrai Associates Inc) <v-hmunibyrai@microsoft.com>
pallavit
reviewed
Mar 28, 2023
pallavit
reviewed
Mar 28, 2023
sdk/translation/Azure.AI.Translation.Text/src/Azure.AI.Translation.Text.csproj
Outdated
Show resolved
Hide resolved
pallavit
reviewed
Mar 28, 2023
sdk/translation/Azure.AI.Translation.Text/api/Azure.AI.TextTranslator.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
pallavit
reviewed
Mar 28, 2023
pallavit
reviewed
Mar 28, 2023
sdk/translation/Azure.AI.Translation.Text/src/TextTranslationClientBuilderExtensions.cs
Show resolved
Hide resolved
m-nash
reviewed
Mar 28, 2023
sdk/translation/Azure.AI.Translation.Text/samples/Sample0_CreateClient.md
Outdated
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/samples/Sample0_CreateClient.md
Outdated
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/samples/Sample0_CreateClient.md
Outdated
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/samples/Sample0_CreateClient.md
Outdated
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/samples/Sample0_CreateClient.md
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/samples/Sample2_Translate.md
Outdated
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/samples/Sample2_Translate.md
Outdated
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/samples/Sample2_Translate.md
Outdated
Show resolved
Hide resolved
joseharriaga
reviewed
Apr 6, 2023
sdk/translation/Azure.AI.Translation.Text/tests/Infrastructure/TextTranslatorTestEnvironment.cs
Outdated
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/src/Models/InputTextWithTranslation.cs
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/tests/TranslationLiveTests.cs
Outdated
Show resolved
Hide resolved
sdk/translation/Azure.AI.Translation.Text/api/Azure.AI.Translation.Text.netstandard2.0.cs
Show resolved
Hide resolved
joseharriaga
approved these changes
Apr 6, 2023
Member
|
cc @Azure/dpg-devs |
pshao25
reviewed
Apr 23, 2023
| /// <param name="context"> The request context, which can override default behaviors of the client pipeline on a per-call basis. </param> | ||
| /// <exception cref="RequestFailedException"> Service returned a non-success status code. </exception> | ||
| /// <returns> The response returned from the service. Details of the response body schema are in the Remarks section below. </returns> | ||
| internal virtual async Task<Response> GetLanguagesAsync(string clientTraceId = null, string scope = null, string acceptLanguage = null, ETag? ifNoneMatch = null, RequestContext context = null) |
Member
There was a problem hiding this comment.
@MikeyMCZ Do you want to make the protocol method internal here? If so, you should mark the operation with decorator @protocol(false) like this Azure/azure-rest-api-specs#23681
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding library for Translation Text Azure service: https://learn.microsoft.com/en-us/azure/cognitive-services/translator/reference/v3-0-translate