health insights sdk for net

[asaflevi-ms]

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

[asaflevi-ms]

This is my first PR for Health Insights - first public preview.

[pallavit]

I do not see an autorest.md file in the PR. Can you please add it and share what settings were used to generate the autorest client?

[chunyu3]

I do not see an autorest.md file in the PR. Can you please add it and share what settings were used to generate the autorest client?

This RP is generated from CADL, not swagger, so there is no autorest.md to set configuration. But @asaflevi-ms You need to add cadl-location.yaml to configure the cadl project. please refer to https://github.com/Azure/azure-sdk-for-net/blob/cabc120930f32aabc57a3556fa9bd60cbd6e4314/doc/DataPlaneCodeGeneration/AzureSDKCodeGeneration_DataPlane_Quickstart.md#configuration-optional

[asaflevi-ms]

/azp run prepare-pipelines

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[asaflevi-ms]

I do not see an autorest.md file in the PR. Can you please add it and share what settings were used to generate the autorest client?

This RP is generated from CADL, not swagger, so there is no autorest.md to set configuration. But @asaflevi-ms You need to add cadl-location.yaml to configure the cadl project. please refer to https://github.com/Azure/azure-sdk-for-net/blob/cabc120930f32aabc57a3556fa9bd60cbd6e4314/doc/DataPlaneCodeGeneration/AzureSDKCodeGeneration_DataPlane_Quickstart.md#configuration-optional

Thank you @chunyu3 for your comment.
@pallavit , PR updated with cadl-project.yaml files (one for each package)
prepare-pipelines run successfully.

if needed, this is my Cadl PR: Azure/azure-rest-api-specs#22990

[azure-sdk]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Health.Insights.ClinicalMatching
Azure.Health.Insights.CancerProfiling

[asaflevi-ms]

@chunyu3, @pallavit

Eventually, the CI fails (https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2631978&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=a880e989-7d1a-5c96-a41f-d540b383cc43.)

I checked and it looks like the TempCadlFiles contains only single directory which is not enough.

I tested it locally and updated cadl-location.yaml to contains additionalDirectories:

"additionalDirectories: specification/cognitiveservices/HealthInsights/."

Now the entire HealthInsights folder is downloaded as expected.
However, since the main directory for the client.cadl is ...../healthinsights.trialmatcher.
node_modules is created under this folder, thus when trying to build other depended cadl files, I am getting:
error import-not-found: Couldn't resolve import "@cadl-lang/rest"

I am not sure how to overcome this issue.
I need your advice for how to resolve this and be able to build multiple packages .
(check my cadl project layout: Azure/azure-rest-api-specs#22990)

[chunyu3]

@chunyu3, @pallavit

Eventually, the CI fails (https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2631978&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=a880e989-7d1a-5c96-a41f-d540b383cc43.)

I checked and it looks like the TempCadlFiles contains only single directory which is not enough.

I tested it locally and updated cadl-location.yaml to contains additionalDirectories:

"additionalDirectories: specification/cognitiveservices/HealthInsights/."

Now the entire HealthInsights folder is downloaded as expected. However, since the main directory for the client.cadl is ...../healthinsights.trialmatcher. node_modules is created under this folder, thus when trying to build other depended cadl files, I am getting: error import-not-found: Couldn't resolve import "@cadl-lang/rest"

I am not sure how to overcome this issue. I need your advice for how to resolve this and be able to build multiple packages . (check my cadl project layout: Azure/azure-rest-api-specs#22990)

Hello @asaflevi-ms If you need additional directory, you can set additionalDirectories in the configuration. you can refer to https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/openai/Azure.AI.OpenAI/cadl-location.yaml.

[lirenhe]

cc @Azure/dpg-devs for awareness

[asaflevi-ms]

Hi @pallavit , @chunyu3
What else need to do to get approved and merged