Only build snippets on latest TFM #34023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes Azure#33975 by reformatting snippets in sdk/core.
heaths
requested review from
JoshLove-msft,
KrzysztofCwalina,
annelo-msft,
benbp,
christothes,
hallipr and
weshaggard
as code owners
ghost
added
the
heaths
commented
Feb 9, 2023
Collaborator
|
API change check API changes are not detected in this pull request. |
christothes
approved these changes
Feb 9, 2023
jsquire
approved these changes
Feb 9, 2023
weshaggard
reviewed
Feb 13, 2023
| <!-- Also test net461 on Windows. --> | ||
| <RequiredTargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(RequiredTargetFrameworks);net461</RequiredTargetFrameworks> | ||
| <!-- But only build snippets for the latest. --> | ||
| <RequiredTargetFrameworks Condition="'$(BuildSnippets)' == 'true'">net7.0</RequiredTargetFrameworks> |
Member
There was a problem hiding this comment.
With this change we definitely need to ensure we always keep BuildSnippets separate from the normal build and package commands. I somewhat fear we might end up dropping target frameworks for what we ship if someone starts passing this property to our normal builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #33975 by reformatting snippets in sdk/core.