Skip to content

Remove dependency on outdated JsonData type #33062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annelo-msft merged 2 commits into from
Dec 15, 2022
Merged

Remove dependency on outdated JsonData type #33062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25788cf
Remove dependency on old JsonData type
annelo-msft Dec 15, 2022
95733df
Remove unused reference to Azure.Core.Experimental
annelo-msft Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/agrifood/Azure.Verticals.AgriFood.Farming/src/Azure.Verticals.AgriFood.Farming.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

<ItemGroup>
<PackageReference Include="Azure.Core" />
<PackageReference Include="Azure.Core.Experimental" />
<PackageReference Include="System.Text.Json" />
</ItemGroup>

Expand Down
1 change: 0 additions & 1 deletion sdk/purview/Azure.Analytics.Purview.Account/src/Azure.Analytics.Purview.Account.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,5 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Azure.Core" />
<PackageReference Include="Azure.Core.Experimental" />
</ItemGroup>
</Project>
10 changes: 4 additions & 6 deletions sdk/purview/Azure.Analytics.Purview.Account/tests/AccountsClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,10 @@ public async Task UpdateTask()
{
var options = new PurviewAccountClientOptions();
PurviewAccountClient client = GetAccountClient();
var data = new JsonData(new Dictionary<string, string>
Response updateResponse = await client.UpdateAccountPropertiesAsync(RequestContent.Create(new Dictionary<string, string>
{
["friendlyName"] = "udpatedFriendlyName"
});
Response updateResponse = await client.UpdateAccountPropertiesAsync(RequestContent.Create(data));
}));
using var jsonDocument = JsonDocument.Parse(GetContentFromResponse(updateResponse));
JsonElement upateBodyJson = jsonDocument.RootElement;
Assert.AreEqual("dotnetLLCPurviewAccount", upateBodyJson.GetProperty("name").GetString());
Expand All @@ -64,11 +63,10 @@ public async Task ListKeysTask()
{
var options = new PurviewAccountClientOptions();
PurviewAccountClient client = GetAccountClient();
var data = new JsonData(new Dictionary<string, string>
Response genResponse = await client.RegenerateAccessKeyAsync(RequestContent.Create(new Dictionary<string, string>
{
["keyType"] = "PrimaryAtlasKafkaKey"
});
Response genResponse = await client.RegenerateAccessKeyAsync(RequestContent.Create(data));
}));
using var jsonDocumentGen = JsonDocument.Parse(GetContentFromResponse(genResponse));
JsonElement genKeyBodyJson = jsonDocumentGen.RootElement;
Assert.AreEqual(genResponse.Status, 200);
Expand Down
1 change: 0 additions & 1 deletion .../Azure.Analytics.Purview.Administration/src/Azure.Analytics.Purview.Administration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Azure.Core" />
<PackageReference Include="Azure.Core.Experimental" />
</ItemGroup>

</Project>
10 changes: 4 additions & 6 deletions sdk/purview/Azure.Analytics.Purview.Administration/tests/AccountsClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,10 @@ public async Task UpdateTask()
{
var options = new PurviewAccountClientOptions();
PurviewAccountClient client = GetAccountClient();
var data = new JsonData(new Dictionary<string, string>
Response updateRespons = await client.UpdateAccountPropertiesAsync(RequestContent.Create(new Dictionary<string, string>
{
["friendlyName"] = "udpatedFriendlyName"
});
Response updateRespons = await client.UpdateAccountPropertiesAsync(RequestContent.Create(data));
}));
using var jsonDocument = JsonDocument.Parse(GetContentFromResponse(updateRespons));
JsonElement upateBodyJson = jsonDocument.RootElement;
Assert.AreEqual("dotnetLLCPurviewAccount", upateBodyJson.GetProperty("name").GetString());
Expand All @@ -64,11 +63,10 @@ public async Task ListKeysTask()
{
var options = new PurviewAccountClientOptions();
PurviewAccountClient client = GetAccountClient();
var data = new JsonData(new Dictionary<string, string>
Response genResponse = await client.RegenerateAccessKeyAsync(RequestContent.Create(new Dictionary<string, string>
{
["keyType"] = "PrimaryAtlasKafkaKey"
});
Response genResponse = await client.RegenerateAccessKeyAsync(RequestContent.Create(data));
}));
using var jsonDocumentGen = JsonDocument.Parse(GetContentFromResponse(genResponse));
JsonElement genKeyBodyJson = jsonDocumentGen.RootElement;
Assert.AreEqual(genResponse.Status, 200);
Expand Down
1 change: 0 additions & 1 deletion sdk/purview/Azure.Analytics.Purview.Catalog/src/Azure.Analytics.Purview.Catalog.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<Compile Include="$(AzureCoreSharedSources)AzureResourceProviderNamespaceAttribute.cs" LinkBase="Shared" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Azure.Core.Experimental" />
<PackageReference Include="Azure.Core" />
</ItemGroup>

Expand Down
1 change: 0 additions & 1 deletion sdk/purview/Azure.Analytics.Purview.Scanning/src/Azure.Analytics.Purview.Scanning.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<Compile Include="$(AzureCoreSharedSources)AzureResourceProviderNamespaceAttribute.cs" LinkBase="Shared" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Azure.Core.Experimental" />
<PackageReference Include="Azure.Core" />
</ItemGroup>

Expand Down