Skip to content

Add service objective and operations .NET client tests, upgrade to Az…#3272

Merged
markcowl merged 7 commits intoAzure:psSdkJson6from
nathannfan:psSdkJson6
May 26, 2017
Merged

Add service objective and operations .NET client tests, upgrade to Az…#3272
markcowl merged 7 commits intoAzure:psSdkJson6from
nathannfan:psSdkJson6

Conversation

@nathannfan
Copy link
Copy Markdown
Contributor

@nathannfan nathannfan commented May 24, 2017

…ure Resource Manager 1.6

Description

Add .NET tests for service objectives and capabilities. Record with Azure Resource Manager version 1.6.

Re-recordings of tests will be done in a separate PR.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • [] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. -
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented May 24, 2017

Can one of the admins verify this patch?

jaredmoo
jaredmoo approved these changes May 24, 2017
View reviewed changes
src/SDKs/SqlManagement/Management.Sql/Properties/AssemblyInfo.cs Outdated
[assembly: AssemblyDescription("Provides management functionality for Microsoft Azure SQL.")]
[assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.4.0.0")]
[assembly: AssemblyFileVersion("1.4.0.1")]
Copy link
Copy Markdown
Contributor

@jaredmoo jaredmoo May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any product code change, or just test code? If test only, then we don't need to publish so I don't think this needs to be bumped

@nathannfan
Copy link
Copy Markdown
Contributor Author

nathannfan commented May 24, 2017

#3267

@shahabhijeet
Copy link
Copy Markdown
Contributor

shahabhijeet commented May 25, 2017

@azuresdkci add to whitelist

@jaredmoo
Copy link
Copy Markdown
Contributor

jaredmoo commented May 25, 2017

Please review because this is blocking other sql sdk changes :) thx

shahabhijeet
shahabhijeet previously requested changes May 25, 2017
View reviewed changes
...qlManagement/Sql.Tests/SessionRecords/Sql.Tests.BlobAuditingTest/TestServerBlobAuditing.json Outdated
"User-Agent": [
"FxVersion/4.6.25009.01",
"Microsoft.Azure.Management.Resources.ResourceManagementClient/1.0.0-preview"
"Microsoft.Azure.Management.ResourceManager.ResourceManagementClient/1.0.0-preview"
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathannfan how is this possible, if you are using 1.6.0 version of resource manager with the new namespace, how come you are still recording the old version?

Copy link
Copy Markdown
Contributor Author

@nathannfan nathannfan May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See, this is why I'm glad you're looking at this :)

Copy link
Copy Markdown
Contributor Author

@nathannfan nathannfan May 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this was an obsolete recording. Removed all obsolete recordings.

@markcowl markcowl dismissed shahabhijeet’s stale review May 26, 2017 01:09

issues resolved

@markcowl markcowl merged commit 342e18b into Azure:psSdkJson6 May 26, 2017
@nathannfan
Copy link
Copy Markdown
Contributor Author

nathannfan commented May 26, 2017

@shahabhijeet , @markcowl thanks for the quick review, guys!

@jaredmoo jaredmoo mentioned this pull request Jun 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markcowl markcowl markcowl approved these changes

+2 more reviewers

@jaredmoo jaredmoo jaredmoo approved these changes

@shahabhijeet shahabhijeet shahabhijeet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nathannfan @azuresdkci @shahabhijeet @jaredmoo @markcowl @msftclas