Cognitive Services version 2017-04-18 by felixwa · Pull Request #3221 · Azure/azure-sdk-for-net

felixwa · 2017-05-16T07:37:38Z

Generates SDK against Cognitive Services version 2017-04-18 swagger
file.
Fixes failed test cases accrodingly and adds 2 more test cases.
Bump version to 1.0.0.0 as Cognitive Services has been GA.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Generates SDK against Cognitive Services version 2017-04-18 swagger file. Fixes failed test cases accrodingly and adds 2 more test cases. Bump version to 1.0.0.0 as Cognitive Services has been GA.

Bump VersionPrefix in csproj to 1.0.0

felixwa · 2017-05-16T07:51:22Z

Generated based on Cognitive Services swagger file 2017-04-18: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-cognitiveservices/2017-04-18/swagger/cognitiveservices.json
Related PRs:
Azure/azure-rest-api-specs#1090
Azure/azure-rest-api-specs#1149
Azure/azure-rest-api-specs#1224

shahabhijeet · 2017-05-16T07:52:35Z

src/SDKs/CognitiveServices/CognitiveServices.Tests/Tests/CognitiveServicesAccountTests.cs

                var rgname = CognitiveServicesManagementTestUtilities.CreateResourceGroup(resourcesClient);

-                var accounts = cognitiveServicesMgmtClient.CognitiveServicesAccounts.ListByResourceGroup(rgname);
+                var accounts = cognitiveServicesMgmtClient.Accounts.ListByResourceGroup(rgname);


@felixwa I see you are still using really old ResourceManger nuget package
Please use the latest nugets for all the dependencies that are used in the tests.
We are asking every RP to update their tests that uses latest nuget packages.

@shahabhijeet I have updated all nuget packages for test project though for ResourceManager (Microsoft.Azure.ResourceManager) I think we have used the latest (1.1.0-preview). I don't see update option for it.

@felixwa the latest version is here: https://www.nuget.org/packages/Microsoft.Azure.Management.ResourceManager/1.6.0-preview

Okay, so actually it is a NEW NuGet package. Added.

shahabhijeet · 2017-05-17T06:57:26Z

...iveServices/Management.CognitiveServices/Microsoft.Azure.Management.CognitiveServices.csproj

  <PropertyGroup>
    <Description>Microsoft Azure Management Cognitive Services Library</Description>
-    <VersionPrefix>0.3.0-preview</VersionPrefix>
+    <VersionPrefix>1.0.0</VersionPrefix>


@felixwa please replace the entire csproj with the following
Microsoft.Azure.Management.CognitiveServices Microsoft Azure Management Cognitive Services Library 1.0.0 Microsoft.Azure.Management.CognitiveServices Microsoft Azure Cognitive Services management;Cognitive Services;Cognitive Services management;REST HTTP client;windowsazureofficial;netcore451511 net452;netstandard1.4
If you want to add ReadMe.txt please add .nuspec file, here is an example
https://docs.microsoft.com/en-us/nuget/schema/nuspec#including-content-files

Updated accordingly.
I will add that additional notice in another PR.

Cleans up .csproj file as shahabhijeet suggested.

Fix format of csproj

Update NuGet pacakges in test project to the latest.

shahabhijeet

Once you are done making suggested changes, remove "needs-revision" flag and add "Need review" flag

shahabhijeet · 2017-05-23T05:27:14Z

src/SDKs/CognitiveServices/CognitiveServices.Tests/CognitiveServices.Tests.csproj

    <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
  </ItemGroup>
+
+  <ItemGroup>


@felixwa any reason these references are added?
All these references are already implicitly added to your project, you do not need them again.
Please remove, or let me know the reason you made this change?

@felixwa in order to use latest ResourceManagement, you will have to add reference to the latest resource manager nuget 1.6.0-preview, and make that change inside CognitiveServicesManagementTestUtilities.cs (that creates the ResourceManagementClient).
We ask RP to re record all tests, that is idea for two reasons:

ResourceManager 1.1.0-preview is really old and if you are still using it, you are not testing latest that is being used by your customers that are creating cognitive services resources.

If you cannot re-record all tests, then start with recording tests that are being used by this particular PR.

Also please remove Compiler Constant #DNX451 from your test/SDK project.
The only constant you should be using is
#if FullNetFx (for Desktop framework version e.g. .NET 4.5.2 .NET 4.6 etc) and if you are targeting .NET Standard, please use
#if !FullNetFx

@shahabhijeet,

Removed those references. They were automatically added when I updated them in NuGet manager.

Add Microsoft.Azure.Management.ResourceManager 1.6.0-preview reference and changed UT code a little bit accordingly.

Re-recorded all unit tests.

Removed that #DNX451 constant.

Generates SDK against Cognitive Services version 2017-04-18 swagger file. Fixes failed test cases accrodingly and adds 2 more test cases. Bump version to 1.0.0.0 as Cognitive Services has been GA.

Bump VersionPrefix in csproj to 1.0.0

Cleans up .csproj file as shahabhijeet suggested.

Fix format of csproj

Update NuGet pacakges in test project to the latest.

Remove DNX451 symbol

…sdk-for-net into Version2017-04-18

1. Adds ref to Microsoft.Azure.Management.ResourceManager 1.6.0-preview 2. Adjust some test code accordingly. 3. Re-record all unit tests.

Cognitive Services version 2017-04-18

a1baf16

Generates SDK against Cognitive Services version 2017-04-18 swagger file. Fixes failed test cases accrodingly and adds 2 more test cases. Bump version to 1.0.0.0 as Cognitive Services has been GA.

msftclas added the cla-not-required label May 16, 2017

Bump VersionPrefix in csproj to 1.0.0

482e64c

Bump VersionPrefix in csproj to 1.0.0

shahabhijeet suggested changes May 17, 2017

View reviewed changes

shahabhijeet added the needs-revision label May 17, 2017

alvadb removed the Fluent label May 18, 2017

felixwa added 3 commits May 18, 2017 12:19

Cleans up csproj

0b48806

Cleans up .csproj file as shahabhijeet suggested.

Fix format of csproj

380c856

Fix format of csproj

Update NuGet pacakges in test project to the latest.

ecadaa8

Update NuGet pacakges in test project to the latest.

shahabhijeet changed the base branch from vs17Dev to psSdkJson6 May 22, 2017 20:13

shahabhijeet suggested changes May 23, 2017

View reviewed changes

felixwa added 7 commits May 26, 2017 18:06

Cognitive Services version 2017-04-18

43feadb

Generates SDK against Cognitive Services version 2017-04-18 swagger file. Fixes failed test cases accrodingly and adds 2 more test cases. Bump version to 1.0.0.0 as Cognitive Services has been GA.

Bump VersionPrefix in csproj to 1.0.0

f368bae

Bump VersionPrefix in csproj to 1.0.0

Cleans up csproj

7099947

Cleans up .csproj file as shahabhijeet suggested.

Fix format of csproj

e4f0c9f

Fix format of csproj

Update NuGet pacakges in test project to the latest.

c3f0fe3

Update NuGet pacakges in test project to the latest.

Remove DNX451 symbol

ccebabf

Remove DNX451 symbol

Merge branch 'Version2017-04-18' of https://github.com/felixwa/azure-…

dae445a

…sdk-for-net into Version2017-04-18

felixwa force-pushed the Version2017-04-18 branch from dae445a to ccebabf Compare May 26, 2017 10:28

Adds ref to Microsoft.Azure.Management.ResourceManager 1.6.0-preview

a1679ec

1. Adds ref to Microsoft.Azure.Management.ResourceManager 1.6.0-preview 2. Adjust some test code accordingly. 3. Re-record all unit tests.

felixwa added needs-review and removed needs-revision labels May 26, 2017

shahabhijeet approved these changes May 26, 2017

View reviewed changes

shahabhijeet merged commit 9ce9125 into Azure:psSdkJson6 May 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cognitive Services version 2017-04-18#3221

Cognitive Services version 2017-04-18#3221
shahabhijeet merged 13 commits intoAzure:psSdkJson6from
felixwa:Version2017-04-18

felixwa commented May 16, 2017 •

edited

Loading

Uh oh!

felixwa commented May 16, 2017

Uh oh!

shahabhijeet May 16, 2017

Uh oh!

felixwa May 18, 2017

Uh oh!

markcowl May 21, 2017

Uh oh!

felixwa May 26, 2017

Uh oh!

shahabhijeet May 17, 2017

Uh oh!

felixwa May 18, 2017

Uh oh!

shahabhijeet left a comment

Uh oh!

shahabhijeet May 23, 2017

Uh oh!

shahabhijeet May 23, 2017 •

edited

Loading

Uh oh!

felixwa May 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

felixwa commented May 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

felixwa commented May 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shahabhijeet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shahabhijeet May 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

felixwa commented May 16, 2017 •

edited

Loading

shahabhijeet May 23, 2017 •

edited

Loading