Skip to content

Port File Staging to VS17#3217

Merged
shahabhijeet merged 2 commits intoAzure:vs17Devfrom
matthchr:feature/filestaging-vs17
May 17, 2017
Merged

Port File Staging to VS17#3217
shahabhijeet merged 2 commits intoAzure:vs17Devfrom
matthchr:feature/filestaging-vs17

Conversation

@matthchr
Copy link
Copy Markdown
Member

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya I used the name and datetime stuff for a purpose... not just to provide uniqueness. and the sleep probably made "uniqueLetsHope" provably "unique". If there is a way of keeping this I'd appreciate it... yes your code is simpler but its harder to use.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this to use a time (for ordering) and a GUID for uniqueness at the end. Plus added some max length truncation where we will truncate the container name if it's too long.

That saves us the Thread (which we can't use) but I think maintains the original behavior.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably no longer linked... the "link" referred to the vs feature.

@matthchr
Copy link
Copy Markdown
Member Author

@shahabhijeet - This can be merged now (if CI passes)

@matthchr matthchr removed the request for review from xingwu1 May 16, 2017 21:22
@shahabhijeet
Copy link
Copy Markdown
Contributor

@matthchr can you resolve the conflicts and push.

@matthchr matthchr force-pushed the feature/filestaging-vs17 branch from 6c27635 to c4abc89 Compare May 17, 2017 17:12
@matthchr
Copy link
Copy Markdown
Member Author

@shahabhijeet Done

@shahabhijeet shahabhijeet merged commit a904529 into Azure:vs17Dev May 17, 2017
@matthchr matthchr deleted the feature/filestaging-vs17 branch May 17, 2017 17:51
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-net Jul 1, 2020
Placed "code" and "message" inside an "error" object so it conforms to the standard error structure (line #3217)
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-net Jul 2, 2020
Placed "code" and "message" inside an "error" object so it conforms to the standard error structure (line #3217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants