Port File Staging to VS17#3217
Conversation
There was a problem hiding this comment.
ya I used the name and datetime stuff for a purpose... not just to provide uniqueness. and the sleep probably made "uniqueLetsHope" provably "unique". If there is a way of keeping this I'd appreciate it... yes your code is simpler but its harder to use.
There was a problem hiding this comment.
I updated this to use a time (for ordering) and a GUID for uniqueness at the end. Plus added some max length truncation where we will truncate the container name if it's too long.
That saves us the Thread (which we can't use) but I think maintains the original behavior.
There was a problem hiding this comment.
probably no longer linked... the "link" referred to the vs feature.
aa1c44f to
6c27635
Compare
|
@shahabhijeet - This can be merged now (if CI passes) |
|
@matthchr can you resolve the conflicts and push. |
6c27635 to
c4abc89
Compare
|
@shahabhijeet Done |
Placed "code" and "message" inside an "error" object so it conforms to the standard error structure (line #3217)
Placed "code" and "message" inside an "error" object so it conforms to the standard error structure (line #3217)
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.