Search SDK: Upgrading 4x-preview to vs17 and netcore#3208
Merged
brjohnstmsft merged 4 commits intoAzure:search-4x-preview-vs17from May 16, 2017
Merged
Conversation
I tried rebasing the search-4x-preview branch to vs17Dev, but the results were very messy, so instead this is just a squash-merge of all the changes. This should differ from search-4x-preview only in the project files and some minor test changes to account for behavioral changes in the latest version of ClientRuntime.
Contributor
|
@azuresdkci test this please |
Contributor
|
@azuresdkci test this please |
1 similar comment
Contributor
|
@azuresdkci test this please |
brjohnstmsft
requested review from
shahabhijeet
and removed request for
seansaleh and
shahabhijeet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-applies the changes from the
search-4x-previewbranch to the newvs17Devbranch. See individual commits for details.FYI @chaosrealm @Yahnoosh @mhko @bernitorres
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.