Add test for AzureRmSqlServerActiveDirectoryAdministrator API #3196

jaczhan · 2017-05-10T18:19:51Z

This is adding test for new Swagger AzureRmSqlServerActiveDirectoryAdministrator API for ActiveDirectoryOperations include:

Create/Update ActiveDirectory Admin
Get ActiveDirectory Admin
Delete ActiveDirectory Admin
Get list of ActiveDirectory Admin

Swagger PR at: Azure/azure-rest-api-specs#1203

azuresdkci · 2017-05-10T18:19:53Z

Can one of the admins verify this patch?

azuresdkci · 2017-05-10T18:19:53Z

Can one of the admins verify this patch?

msftclas · 2017-05-10T18:19:55Z

@jaczhan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

…into vs17Dev

nathannfan · 2017-05-10T21:05:51Z

src/SDKs/SqlManagement/Sql.Tests/AzureRmSqlServerActiveDirectoryAdministratorTest.cs

+                Assert.Equal(aadAdmin, getResult.Login);
+                Assert.Equal(new Guid("5e90ef3b-9b42-4777-819b-25c36961ea4d"), getResult.Sid);
+                Assert.Equal(new Guid("72f988bf-86f1-41af-91ab-2d7cd011db47"), getResult.TenantId);
+


Add a check for list here too?

nathannfan

Looks good to me if it passes validation.

…into vs17Dev

shahabhijeet · 2017-05-10T23:29:03Z

src/SDKs/SqlManagement/Sql.Tests/Sql.Tests.csproj

    <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
  </ItemGroup>
+  <ItemGroup>
+    <PackageReference Update="Microsoft.Rest.ClientRuntime.Azure" Version="3.3.5" />


@jaczhan you don't need to add these references, they get implicitly added.

shahabhijeet · 2017-05-10T23:30:36Z

src/SDKs/SqlManagement/Sql.Tests/AzureRmSqlServerActiveDirectoryAdministratorTest.cs

+{
+    public class AzureRmSqlServerActiveDirectoryAdministratorTest
+    {
+        [Fact]


@jaczhan please record test using latest nugets (e.g. 1.5.0 version of Resource manager) Currently you are using 1.1.0-preview version of Resource Manager.
All new tests should be using latest version of Resource Manager.

how do I switch to the latest nugets?

just updated

…into vs17Dev

shahabhijeet · 2017-05-11T18:29:51Z

src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj

    <TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
  </PropertyGroup>
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" />


@jaczhan any reason you need this nuget in your SQL package?
The requirement was only for recording new test, so your other change is all you need.
You don't want additional dependency on your SQL SDK package.
Please revert "this" particular change.
Please keep your other change that you made in the test project (that is what I had asked for)

shahabhijeet · 2017-05-11T18:30:34Z

src/SDKs/SqlManagement/Sql.Tests/Sql.Tests.csproj

  </ItemGroup>
-</Project>
+  <ItemGroup>
+    <PackageReference Update="Microsoft.Rest.ClientRuntime.Azure.TestFramework" Version="1.6.0" />


@jaczhan you do not need this, this is being added to every project.
Any reason you had to add reference to TestFramework?
You can remove this package reference.

…into vs17Dev

jaczhan

remove Resource Manager 1.6

shahabhijeet · 2017-05-11T21:36:19Z

@jaczhan add to whitelist

jaczhan · 2017-05-11T21:41:12Z

Adding test for Swagger AzureRmSqlServerActiveDirectoryAdministrator

Azure/azure-rest-api-specs#1203

jaczhan

changes made to fix 1.6 tag

…into vs17Dev

jaredmoo · 2017-05-22T22:43:45Z

We will rerecord the tests separately - #3267

…into vs17Dev

shahabhijeet · 2017-05-23T05:09:18Z

@jaczhan looks good, as soon as CI passes this can be merged.

Add test for AzureRmSqlServerActiveDirectoryAdministratorTest

650c595

msftclas added the cla-not-required label May 10, 2017

jaczhan added 4 commits May 10, 2017 11:24

Add test for AzureRmSqlServerActiveDirectoryAdministratorTest

e69d515

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

4e46ebf

…into vs17Dev

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

a235c76

…into vs17Dev

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

e8393b6

…into vs17Dev

jaczhan requested a review from nathannfan May 10, 2017 18:48

nathannfan reviewed May 10, 2017

View reviewed changes

nathannfan approved these changes May 10, 2017

View reviewed changes

jaczhan added 3 commits May 10, 2017 14:19

Merge branch 'vs17Dev' into vs17Dev

e1a867b

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

cc0bf67

…into vs17Dev

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

286b0f3

…into vs17Dev

shahabhijeet suggested changes May 10, 2017

View reviewed changes

jaczhan added 2 commits May 10, 2017 17:24

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

1da9ef9

…into vs17Dev

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

1e46a01

…into vs17Dev

shahabhijeet added the needs-revision label May 11, 2017

Update Sql.Tests.csproj

c589c8e

shahabhijeet suggested changes May 11, 2017

View reviewed changes

jaczhan added 4 commits May 11, 2017 14:01

Update Sql.Tests.csproj

4549c0f

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

761824b

…into vs17Dev

Update Sql.Tests.csproj

4a79d09

Update Sql.Tests.csproj

8fab667

jaczhan commented May 11, 2017

View reviewed changes

Merge branch 'vs17Dev' into vs17Dev

35f0428

jaczhan changed the title ~~Add test for AzureRmSqlServerActiveDirectoryAdministratorTest~~ Add test for AzureRmSqlServerActiveDirectoryAdministrator API. https://github.com/Azure/azure-rest-api-specs/pull/1203 May 11, 2017

jaczhan changed the title ~~Add test for AzureRmSqlServerActiveDirectoryAdministrator API. https://github.com/Azure/azure-rest-api-specs/pull/1203~~ Add test for AzureRmSqlServerActiveDirectoryAdministrator API May 11, 2017

jaczhan commented May 11, 2017

View reviewed changes

shahabhijeet and others added 3 commits May 11, 2017 16:46

Merge branch 'vs17Dev' into vs17Dev

1eeb26b

Merge branch 'vs17Dev' into vs17Dev

8f462a0

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

d6b18ef

…into vs17Dev

alvadb removed the Fluent label May 18, 2017

shahabhijeet changed the base branch from vs17Dev to psSdkJson6 May 22, 2017 20:12

jaczhan mentioned this pull request May 22, 2017

Re-record SQL tests with ResourceManager client 1.6 #3267

Closed

jaczhan added 4 commits May 22, 2017 16:14

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

51694a8

…into vs17Dev

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

2c5b379

…into vs17Dev

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

ddd5cde

…into vs17Dev

Merge branch 'vs17Dev' of https://github.com/jaczhan/azure-sdk-for-net …

3514dba

…into vs17Dev

shahabhijeet merged commit b59cca5 into Azure:psSdkJson6 May 23, 2017

jaredmoo mentioned this pull request Jun 7, 2017

SQL server AD identity and data encryption support #3334

Merged

8 tasks

Add test for AzureRmSqlServerActiveDirectoryAdministrator API #3196

Add test for AzureRmSqlServerActiveDirectoryAdministrator API #3196

Uh oh!

Conversation

jaczhan commented May 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azuresdkci commented May 10, 2017

Uh oh!

azuresdkci commented May 10, 2017

Uh oh!

msftclas commented May 10, 2017

Uh oh!

nathannfan May 10, 2017

Choose a reason for hiding this comment

Uh oh!

nathannfan left a comment

Choose a reason for hiding this comment

Uh oh!

shahabhijeet May 10, 2017

Choose a reason for hiding this comment

Uh oh!

shahabhijeet May 10, 2017

Choose a reason for hiding this comment

Uh oh!

jaczhan May 11, 2017

Choose a reason for hiding this comment

Uh oh!

jaczhan May 11, 2017

Choose a reason for hiding this comment

Uh oh!

shahabhijeet May 11, 2017

Choose a reason for hiding this comment

Uh oh!

shahabhijeet May 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaczhan left a comment

Choose a reason for hiding this comment

Uh oh!

shahabhijeet commented May 11, 2017

Uh oh!

jaczhan commented May 11, 2017

Uh oh!

jaczhan left a comment

Choose a reason for hiding this comment

Uh oh!

jaredmoo commented May 22, 2017

Uh oh!

shahabhijeet commented May 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jaczhan commented May 10, 2017 •

edited

Loading

shahabhijeet May 11, 2017 •

edited

Loading