Skip to content

Added support for VirtualNetworkUsages API to Virtual Networks#3193

Merged
shahabhijeet merged 4 commits intoAzure:vs17Devfrom
anton-evseev:vnet-usage-api
May 15, 2017
Merged

Added support for VirtualNetworkUsages API to Virtual Networks#3193
shahabhijeet merged 4 commits intoAzure:vs17Devfrom
anton-evseev:vnet-usage-api

Conversation

@anton-evseev
Copy link
Copy Markdown
Contributor

Description

Added support for VirtualNetworkUsages API to Virtual Networks
Swagger PR: Azure/azure-rest-api-specs#1168


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

1 similar comment
@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@msftclas
Copy link
Copy Markdown

@number213,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link
Copy Markdown

@number213, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@shahabhijeet
Copy link
Copy Markdown
Contributor

@azuresdkci add to whitelist

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@number213 all new tests should be using latest Resource Manager nuget package.

@anton-evseev
Copy link
Copy Markdown
Contributor Author

@shahabhijeet re-recorded new test with the latest Resource Manager


using (MockContext context = MockContext.Start(this.GetType().FullName))
{
var resourcesClient = ResourcesManagementTestUtilities.GetResourceManagementClientWithHandler(context, handler1);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@number213 I don't see any changes to code that creates the actual Resource Manager client.
Could you point me to that change?

@anton-evseev
Copy link
Copy Markdown
Contributor Author

@shahabhijeet sorry for taking so long, finally got what you meant. Updated Virtual Network tests to use latest Resource Manager instead of depreciated one.

@shahabhijeet shahabhijeet merged commit 98c109a into Azure:vs17Dev May 15, 2017
@anton-evseev anton-evseev deleted the vnet-usage-api branch October 3, 2017 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants