Updated AzureCloud endpoint; Added support for AzureUSGov & AzureGermany

[horrion]

Description

View this for further information. This is the Pull Request for the vs17Dev branch.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• I have read the contribution guidelines.
• The pull request does not introduce breaking changes.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

SDK Generation Guidelines

• If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
• The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
• The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

[msftclas]

@horrion,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

[msftclas]

@horrion, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

[shahabhijeet]

@horrion any reason this is needed? What is causing your make this change? Would like to understand?

[horrion]

Please refer to @markcowl 's and my comments here: #3030

login.microsoftonline.com is the new ARM endpoint that supports both the ARM and the Classic environment. As far as I know people are encouraged to use the new endpoint.

[shahabhijeet]

@horrion
Have you tested if these changes are required and will work?
Where are the tests for this newly added properties?

[horrion]

How would you like me to test these changes?

[shahabhijeet]

@horrion Apart from the endpoints (and thank you for adding the ARM endpoint), I am more interested to know if these endpoints do work for authenticating against various cloud environments? And hence wanted to know if you have used the piece of code that you have contributed?
Or was your intention to simply add those endpoints?
Because majority of our Authentication scenarios are via our TestFramework when automating our tests
https://github.com/Azure/azure-sdk-for-net/blob/vs17Dev/src/SdkCommon/TestFramework/ClientRuntime.Azure.TestFramework/TestEnvironment.cs#L254