Merged
Conversation
ghost
added
the
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTargetScaler.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Sep 26, 2022
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTargetScaler.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Sep 26, 2022
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsReceiver.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Sep 26, 2022
...servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusListener.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Sep 26, 2022
...Microsoft.Azure.WebJobs.Extensions.ServiceBus/tests/Listeners/ServiceBusScaleMonitorTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Sep 26, 2022
.../Microsoft.Azure.WebJobs.Extensions.ServiceBus/tests/Listeners/ServiceBusTargetScalerTest.cs
Outdated
Show resolved
Hide resolved
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTargetScaler.cs
Show resolved
Hide resolved
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusScaleMonitor.cs
Show resolved
Hide resolved
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsReceiver.cs
Outdated
Show resolved
Hide resolved
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsReceiver.cs
Outdated
Show resolved
Hide resolved
alrod
requested review from
chiangvincent and
mathewc
and removed request for
chiangvincent
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTargetScaler.cs
Outdated
Show resolved
Hide resolved
seilorjunior
reviewed
Oct 5, 2022
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTargetScaler.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 12, 2022
sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Constants.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 12, 2022
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 12, 2022
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTargetScaler.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 12, 2022
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTargetScaler.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 12, 2022
...ebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTriggerMetrics.cs
Outdated
Show resolved
Hide resolved
alrod
requested review from
chiangvincent,
mathewc and
seilorjunior
and removed request for
chiangvincent and
seilorjunior
mathewc
reviewed
Nov 7, 2022
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Nov 7, 2022
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
2 tasks
Collaborator
|
API change check API changes are not detected in this pull request. |
8 tasks
alrod
requested review from
JoshLove-msft,
benbp,
hallipr,
jsquire and
weshaggard
as code owners
jsquire
reviewed
Feb 9, 2023
...servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusListener.cs
Outdated
Show resolved
Hide resolved
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
alrod
requested review from
chiangvincent and
jsquire
and removed request for
chiangvincent
jsquire
approved these changes
Feb 15, 2023
...bus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs
Outdated
Show resolved
Hide resolved
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTargetScaler.cs
Show resolved
Hide resolved
...icebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusTargetScaler.cs
Outdated
Show resolved
Hide resolved
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support "Target Base Scale" for "Runtime Driven Scale" the ServiceBus extension needs to implement ITargetScalerProvider and ITargetScaler which was introduced in "Microsoft.Azure.WebJobs.3.0.36". The approach is similar to incremental scale -
IScaleMonitorProvider/IScaleMonitor.The PR is similar to the EventHub PR:
#33675
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.