Skip to content

Added test for Performance Plus and Bursting enabled time. #30625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haagha merged 3 commits into from
Aug 22, 2022
Merged

Added test for Performance Plus and Bursting enabled time. #30625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d58d591
Added test for Performance Plus and Bursting enabled time.
Aug 18, 2022
85ac743
Added test for Performance Plus and Bursting enabled time.
Aug 18, 2022
35fc881
Added a session file
Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdk/compute/Microsoft.Azure.Management.Compute/tests/DiskRPTests/DiskRPScenarioTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ public void Disk_CRUD_PremiumDiskWithBursting()
PremiumDisk_CRUD_Execute(DiskCreateOption.Import, "Disk_CRUD_PremiumDiskWithBursting", tier: "P30", diskSizeGB: 1024, burstingEnabled: true, location: "eastus2euap");
}

[Fact]
public void Disk_CRUD_PerformancePlusDiskWithBursting()
{
PremiumDisk_CRUD_Execute(DiskCreateOption.Empty, "Disk_CRUD_PerformancePlusDiskWithBursting", tier: "P30", diskSizeGB: 1024, burstingEnabled: true, location: "eastus2euap", isPerformancePlus : true);
}

[Fact]
public void Snapshot_CRUD_EmptyDisk()
{
Expand Down
13 changes: 11 additions & 2 deletions sdk/compute/Microsoft.Azure.Management.Compute/tests/DiskRPTests/DiskRPTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ protected void Disk_CRUD_Execute(string diskCreateOption, string methodName, int

}

protected void PremiumDisk_CRUD_Execute(string diskCreateOption, string methodName, int? diskSizeGB = null, string tier = null, bool? burstingEnabled = null, string location = null, IList<string> zones = null)
protected void PremiumDisk_CRUD_Execute(string diskCreateOption, string methodName, int? diskSizeGB = null, string tier = null, bool? burstingEnabled = null, string location = null, IList<string> zones = null, bool? isPerformancePlus = null)
{
using (MockContext context = MockContext.Start(this.GetType(), methodName))
{
Expand All @@ -140,6 +140,7 @@ protected void PremiumDisk_CRUD_Execute(string diskCreateOption, string methodNa
};
disk.Tier = tier;
disk.BurstingEnabled = burstingEnabled;
disk.CreationData.PerformancePlus = isPerformancePlus;

try
{
Expand All @@ -161,12 +162,20 @@ protected void PremiumDisk_CRUD_Execute(string diskCreateOption, string methodNa
Validate(disk, diskOut, DiskRPLocation);
Assert.Equal(tier, diskOut.Tier);
Assert.Equal(burstingEnabled, diskOut.BurstingEnabled);
if (burstingEnabled == true)
{
Assert.NotNull(diskOut.BurstingEnabledTime);
}

// Get
diskOut = m_CrpClient.Disks.Get(rgName, diskName);
Validate(disk, diskOut, DiskRPLocation);
Assert.Equal(tier, diskOut.Tier);
Assert.Equal(burstingEnabled, diskOut.BurstingEnabled);
if (burstingEnabled == true)
{
Assert.NotNull(diskOut.BurstingEnabledTime);
}

// Get disk access
AccessUri accessUri = m_CrpClient.Disks.GrantAccess(rgName, diskName, AccessDataDefault);
Expand Down Expand Up @@ -215,7 +224,6 @@ protected void PremiumDisk_CRUD_Execute(string diskCreateOption, string methodNa
m_ResourcesClient.ResourceGroups.Delete(rgName);
}
}

}

protected void SSDZRSDisk_CRUD_Execute(string diskCreateOption, string accountType, string methodName, int? diskSizeGB = null, string tier = "E4", string location = null)
Expand Down Expand Up @@ -2021,6 +2029,7 @@ protected void Validate(Disk diskExpected, Disk diskActual, string location, boo
Assert.Equal(creationDataExp.SourceUri, creationDataAct.SourceUri);
Assert.Equal(creationDataExp.SourceResourceId, creationDataAct.SourceResourceId);
Assert.Equal(creationDataExp.StorageAccountId, creationDataAct.StorageAccountId);
Assert.Equal(creationDataExp.PerformancePlus, creationDataAct.PerformancePlus);

// Image reference
ImageDiskReference imgRefExp = creationDataExp.GalleryImageReference ?? creationDataExp.ImageReference;
Expand Down
Loading