Gallery 2022_03_03 by tiregan · Pull Request #29817 · Azure/azure-sdk-for-net

tiregan · 2022-07-12T18:46:59Z

Contributing to the Azure SDK

Generated from swagger PR: Azure/azure-rest-api-specs#20398

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

check-enforcer · 2022-07-12T18:57:31Z

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

Yao725 · 2022-07-15T02:07:37Z

/azp run net - mgmt - ci

azure-pipelines · 2022-07-15T02:07:42Z

Pull request contains merge conflicts.

Yao725

@tiregan could you please resolve the merge conflicts?

…egan

...compute/Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryApplicationVersion.cs

...e/Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryApplicationVersionUpdate.cs

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryImageVersion.cs

...compute/Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryImageVersionUpdate.cs

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryOSDiskImage.cs

Sandido · 2022-08-02T14:09:23Z

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SharingProfile.cs

        /// shared to community.
        /// </summary>
        [JsonProperty(PropertyName = "communityGalleryInfo")]
-        public object CommunityGalleryInfo { get; set; }


This is fixing a bug.

…ted swagger.

sdk/compute/Microsoft.Azure.Management.Compute/src/Customizations/GalleryApplicationVersion.cs

...ute/Microsoft.Azure.Management.Compute/src/Customizations/GalleryApplicationVersionUpdate.cs

clean key value to allowed 'sanitized'

Yao725

I still find some breaking changes in this PR. Could you please take a look at below comments to see if we can do something in customization to minimize the breaking change, thanks.

P.S: I think some of them might be hard to support the backward compatibility by customization. If so, we need to bump the major package version before release.

Yao725 · 2022-09-02T09:32:41Z

...pute/Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryArtifactVersionSource.cs

-        /// <param name="uri">The uri of the gallery artifact version source.
-        /// Currently used to specify vhd/blob source.</param>
-        public GalleryArtifactVersionSource(string id = default(string), string uri = default(string))
+        public GalleryArtifactVersionSource(string id = default(string))


This is a breaking change.

Yao725 · 2022-09-02T09:32:57Z

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryDataDiskImage.cs

        /// values are 'None', 'ReadOnly', and 'ReadWrite'. Possible values
        /// include: 'None', 'ReadOnly', 'ReadWrite'</param>
-        public GalleryDataDiskImage(int lun, int? sizeInGB = default(int?), HostCaching? hostCaching = default(HostCaching?), GalleryArtifactVersionSource source = default(GalleryArtifactVersionSource))
+        public GalleryDataDiskImage(int lun, int? sizeInGB = default(int?), HostCaching? hostCaching = default(HostCaching?), GalleryDiskImageSource source = default(GalleryDiskImageSource))


Breaking change.

Yao725 · 2022-09-02T09:33:17Z

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryDiskImage.cs

        /// values are 'None', 'ReadOnly', and 'ReadWrite'. Possible values
        /// include: 'None', 'ReadOnly', 'ReadWrite'</param>
-        public GalleryDiskImage(int? sizeInGB = default(int?), HostCaching? hostCaching = default(HostCaching?), GalleryArtifactVersionSource source = default(GalleryArtifactVersionSource))
+        public GalleryDiskImage(int? sizeInGB = default(int?), HostCaching? hostCaching = default(HostCaching?), GalleryDiskImageSource source = default(GalleryDiskImageSource))


Breaking change.

Yao725 · 2022-09-02T09:33:27Z

...Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryImageVersionStorageProfile.cs

        /// </summary>
        /// <param name="dataDiskImages">A list of data disk images.</param>
-        public GalleryImageVersionStorageProfile(GalleryArtifactVersionSource source = default(GalleryArtifactVersionSource), GalleryOSDiskImage osDiskImage = default(GalleryOSDiskImage), IList<GalleryDataDiskImage> dataDiskImages = default(IList<GalleryDataDiskImage>))
+        public GalleryImageVersionStorageProfile(GalleryArtifactVersionFullSource source = default(GalleryArtifactVersionFullSource), GalleryOSDiskImage osDiskImage = default(GalleryOSDiskImage), IList<GalleryDataDiskImage> dataDiskImages = default(IList<GalleryDataDiskImage>))


Breaking change.

Yao725 · 2022-09-02T09:33:40Z

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/GalleryOSDiskImage.cs

        /// values are 'None', 'ReadOnly', and 'ReadWrite'. Possible values
        /// include: 'None', 'ReadOnly', 'ReadWrite'</param>
-        public GalleryOSDiskImage(int? sizeInGB = default(int?), HostCaching? hostCaching = default(HostCaching?), GalleryArtifactVersionSource source = default(GalleryArtifactVersionSource))
+        public GalleryOSDiskImage(int? sizeInGB = default(int?), HostCaching? hostCaching = default(HostCaching?), GalleryDiskImageSource source = default(GalleryDiskImageSource))


Breaking change.

Yao725 · 2022-09-02T09:35:37Z

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SharingProfile.cs

        /// </summary>
        [JsonProperty(PropertyName = "communityGalleryInfo")]
-        public object CommunityGalleryInfo { get; set; }
+        public CommunityGalleryInfo CommunityGalleryInfo { get; set; }


It's nice to change the type from object to the specific type CommunityGalleryInfo, but it is still a breaking change.

@Yao725 , and the breaking change was approved in the Swagger PR by the breaking change review board. Mostly because the functionality was broken without these changes.
I am unaware of any customizations that can be done to mitigate these different breaking changes. If you have any advice, please let us know.

Sandido · 2022-09-09T14:16:51Z

I still find some breaking changes in this PR. Could you please take a look at below comments to see if we can do something in customization to minimize the breaking change, thanks.

P.S: I think some of them might be hard to support the backward compatibility by customization. If so, we need to bump the major package version before release.

Yes, the major version will be updated.

sdk tests for 03 03

ba3deac

tiregan requested review from ArcturusZhang, ArthurMa1978, Yao725, archerzz and fengzhou-msft as code owners July 12, 2022 18:47

openapi-assignment-bot bot assigned Yao725 Jul 12, 2022

ghost added the Compute label Jul 12, 2022

Yao725 requested changes Jul 15, 2022

View reviewed changes

Merge branch 'feature/gallery-2022-03-03' into gallery-2022-03-03-tir…

d4c740c

…egan

Sandido suggested changes Aug 2, 2022

View reviewed changes

tiregan added 2 commits August 3, 2022 12:05

Add customizations for changed constructors. Regenerate based on upda…

a0e375d

…ted swagger.

fix all tests adn add session records

68cf46a

Sandido suggested changes Aug 16, 2022

View reviewed changes

sdk/compute/Microsoft.Azure.Management.Compute/src/Customizations/GalleryApplicationVersion.cs Show resolved Hide resolved

...ute/Microsoft.Azure.Management.Compute/src/Customizations/GalleryApplicationVersionUpdate.cs Outdated Show resolved Hide resolved

fix application version customizations.

0338034

Sandido approved these changes Aug 29, 2022

View reviewed changes

tiregan and others added 2 commits September 1, 2022 10:56

resovle conflicts

80f6efa

Update GalleryApplicationVersion_CRUD_Tests.json

64ab05a

clean key value to allowed 'sanitized'

Yao725 reviewed Sep 2, 2022

View reviewed changes

Yao725 approved these changes Sep 7, 2022

View reviewed changes

Yao725 merged commit 4bf84f5 into Azure:feature/gallery-2022-03-03 Sep 7, 2022

Conversation

tiregan commented Jul 12, 2022 • edited by Sandido Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contributing to the Azure SDK

Uh oh!

check-enforcer bot commented Jul 12, 2022

Uh oh!

Yao725 commented Jul 15, 2022

Uh oh!

azure-pipelines bot commented Jul 15, 2022

Uh oh!

Yao725 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Yao725 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sandido commented Sep 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tiregan commented Jul 12, 2022 •

edited by Sandido

Loading