Automated Transfer Validation API#29778
Merged
jaschrep-msft merged 47 commits intoAzure:mainfrom Jul 15, 2022
Merged
Conversation
…o transfer-validation-new pull an sln fix
…o transfer-validation-new pull sln fix
…o transfer-validation-new pulls a core fix to recording
…o transfer-validation-new
resolving todos formatting test passing
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.Storage.Blobs |
jaschrep-msft
requested review from
KrzysztofCwalina,
amnguye,
seanmcc-msft and
tg-msft
as code owners
sdk/storage/Azure.Storage.Blobs/api/Azure.Storage.Blobs.netstandard2.0.cs
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Blobs/src/Generated/BlockBlobRestClient.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Blobs/src/Models/BlobDownloadOptions.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Common/src/Shared/TransferValidationOptionsExtensions.cs
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Files.DataLake/src/DataLakeFileClient.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Files.DataLake/src/DataLakeFileClient.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Files.DataLake/src/DataLakeFileClient.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Files.DataLake/src/DataLakeFileClient.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Files.DataLake/src/DataLakeFileClient.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Files.DataLake/src/DataLakeFileClient.cs
Outdated
Show resolved
Hide resolved
seanmcc-msft
approved these changes
Jul 15, 2022
Member
seanmcc-msft
left a comment
seanmcc-msft
left a comment
There was a problem hiding this comment.
Approved pending CI and changelogs
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
* Reenabled validationOptions on 1:1 blob uploads * restored block blob hashing tests * restored pageblob hashing tests * reenabled hashing on blob partitioned upload * fixes for samples projects * transfer validation in Azure.Storage.Blobs.Perf * added uploadfromfile to Azure.Storage.Blobs.Perf * file cleanup * put blob supports crc * perf fix * reenabled hashing on blob openwrite * recording * reenabled datalake hashing on upload * checkpoint * Blob download transactional checksums * block blob upload hashing * fixed tests * datalake and shares reenabled * tests & bug fixes * new openwrite hashing tests * partitioned upload validation tests * parallel download validation tests * recording * testing and bug fixes * recording * test fixes * updates on initial review resolving todos formatting test passing * standardize options names; exportapi * cleanup * minor PR feedback * fix build * default params * fix overloads * changes from shifting defaults * update test mocks * remove default params * codegen source and exportapi * update snippets * codegen * generate and internalize model * removed unnecessary constructor * changelog Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new API for automated SDK validation of checksums on transfers.
#27259 removed this feature from GA release. This reenables the feature. Code review can be kept to netstandard2.0 files and clients themselves, as the core code has already gone through thorough review.