Azure Machine Learning WebServicesRP new API version by NonStatic2014 · Pull Request #2921 · Azure/azure-sdk-for-net

NonStatic2014 · 2017-03-10T20:10:00Z

Description

Azure Machine Learning Web Services RP is publishing a new version of API. The .Net SDK needs to be regenerated from a new swagger spec. The pull request of swagger spec change is here: Azure/azure-rest-api-specs#1019. Compare with the existing preview version, this is a breaking change according to breaking changes

Scenario Tests have been updated and two new test cases were added to cover new scenarios.

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

…-for-net into new_version # Conflicts: # src/ResourceManagement/MachineLearning/Microsoft.Azure.Management.MachineLearning/Properties/AssemblyInfo.cs # src/ResourceManagement/MachineLearning/Microsoft.Azure.Management.MachineLearning/project.json

markcowl · 2017-03-10T20:23:36Z

@NonStatic2014 Please change the PR title to be more descriptive. You realize that you checked a box saying the PR had a descriptive title, right? :-)

NonStatic2014 · 2017-03-10T20:30:48Z

Good catch Mark! I reopen the web page but forget to update the title. Now it is updated.

…cryption, not auth.

NonStatic2014 · 2017-03-17T08:02:38Z

I have run the following command locally and exit successfully. Not sure why lab build keep failing.

.\CredentialScanner.exe -I D:\code\GitHub\azure-sdk-for-net\src\ResourceManagement\MachineLearning -S Searchers\buildsearchers.xml -O d:\temp\scan1 -t -v > Result.txt
Result.txt

…dScan in the lab build.

cormacpayne

@NonStatic2014 Hey Klein, some minor comments that need to be resolved before the swagger gets merged and we can review the generated code.

cormacpayne · 2017-03-21T16:43:16Z

@@ -1,5 +1,5 @@
 {
-  "version": "0.10.0-preview",
+  "version": "1.0.0",


@NonStatic2014 this should be version 1.0.0-preview (or 0.11.0-preview) since you are introducing breaking changes

This version is going to be the GA version, so we expect it is called 1.0.0.

We still require the package to be in preview when breaking changes are introduced to the SDK, and after enough time to ensure it is stable, you can remove the -preview suffix and re-publish a new version

cormacpayne · 2017-03-21T16:43:50Z

 set autoRestVersion=0.17.0-Nightly20160824

-set webServicesSpecFile="https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-machinelearning/2016-05-01-preview/swagger/webservices.json"
+set webServicesSpecFile="https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-machinelearning/2017-01-01/swagger/webservices.json"


@NonStatic2014 please use the URL containing the commit Id when the spec gets merged instead of the URL containing the branch

cormacpayne · 2017-03-21T16:47:02Z

@@ -8,7 +8,7 @@ setlocal

 set autoRestVersion=0.17.0-Nightly20160824


@NonStatic2014 AutoRest is now at version 1.0.x. Please refer to aka.ms/autorest/install for more information on how to install and use the latest version(s).

Then please ignore this cmd file and we are going to follow the new instruction generate code locally.

We would still prefer if you updated this file with the version of AutoRest used (even if it's from the new instructions); it let's us know that you aren't using an outdated version of AutoRest if we were to just look at this file

shahabhijeet · 2017-03-27T23:03:37Z

@NonStatic2014 please reopen this PR once the swagger PR is merged.
We are trying to accurately asses our SLA and opening a PR which is not ready to be reviewed. We will not review SDK PR unless swagger PR is merged.

NonStatic2014 added 10 commits January 5, 2017 17:20

Initial change for a new version

b242ffe

Update the POST operation id

60f1db8

POST method update

3a65817

Make the POST call long running operation and handle the request id.

ee71483

Update existing test cases to work with new API version.

366f97a

Add new test case for POST

d18179c

Add test case for large payload scenario.

2b0727a

Description update according to swagger update

15f68d8

Update generate.cmd to point to new swagger spec

d889213

msftclas added the cla-not-required label Mar 10, 2017

markcowl added the needs-revision label Mar 10, 2017

NonStatic2014 changed the title ~~New version~~ Azure Machine Learning WebServicesRP new API version Mar 10, 2017

NonStatic2014 added 5 commits March 16, 2017 15:55

Suppress CredScan message for certificate thumbprint, which is for en…

89bea37

…cryption, not auth.

Replace real thumbprints with dummy strings

f09574b

More thumbprints replaced with dummy strings

7c527df

Replace hardcoded web service keys with dummy strings

4e55fcf

Replace keys and thumbprints with dummy strings

6507d34

Remove all encrypted content which were treated as credentials by Cre…

1f87ba4

…dScan in the lab build.

cormacpayne mentioned this pull request Mar 21, 2017

Azure Machine Learning WebServicesRP new API version Azure/azure-rest-api-specs#1019

Merged

cormacpayne added spec-not-merged and removed needs-revision labels Mar 21, 2017

cormacpayne suggested changes Mar 21, 2017

View reviewed changes

shahabhijeet closed this Mar 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure Machine Learning WebServicesRP new API version#2921

Azure Machine Learning WebServicesRP new API version#2921
NonStatic2014 wants to merge 16 commits into
Azure:AutoRestfrom
NonStatic2014:new_version

NonStatic2014 commented Mar 10, 2017 •

edited

Loading

Uh oh!

markcowl commented Mar 10, 2017

Uh oh!

NonStatic2014 commented Mar 10, 2017

Uh oh!

NonStatic2014 commented Mar 17, 2017

Uh oh!

cormacpayne left a comment

Uh oh!

cormacpayne Mar 21, 2017

Uh oh!

NonStatic2014 Mar 22, 2017

Uh oh!

cormacpayne Mar 22, 2017

Uh oh!

cormacpayne Mar 21, 2017

Uh oh!

cormacpayne Mar 21, 2017

Uh oh!

NonStatic2014 Mar 22, 2017

Uh oh!

cormacpayne Mar 22, 2017

Uh oh!

shahabhijeet commented Mar 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -8,7 +8,7 @@ setlocal

		set autoRestVersion=0.17.0-Nightly20160824

Conversation

NonStatic2014 commented Mar 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

markcowl commented Mar 10, 2017

Uh oh!

NonStatic2014 commented Mar 10, 2017

Uh oh!

NonStatic2014 commented Mar 17, 2017

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shahabhijeet commented Mar 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NonStatic2014 commented Mar 10, 2017 •

edited

Loading