Skip to content

Initial SQL Capabilities SDK commit, with Capabilities API and comments#2914

Closed
nathannfan wants to merge 4 commits intoAzure:AutoRestfrom
nathannfan:AutoRest_Capabilities
Closed

Initial SQL Capabilities SDK commit, with Capabilities API and comments#2914
nathannfan wants to merge 4 commits intoAzure:AutoRestfrom
nathannfan:AutoRest_Capabilities

Conversation

@nathannfan
Copy link
Contributor

@nathannfan nathannfan commented Mar 9, 2017

Description

Add Capabilities API to .NET SDK. Updated some descriptions to exclude enumeration values and simply reference the Capabilities API.

Swagger: Azure/azure-rest-api-specs#1015


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
  • The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

@msftclas
Copy link

msftclas commented Mar 9, 2017

@nathannfan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@cormacpayne
Copy link
Member

@nathannfan please fill out the PR checklist provided, as well as provide a link to the corresponding rest-api-specs PR that this code was generated from

@nathannfan
Copy link
Contributor Author

@cormacpayne Done. Haven't updated generate.cmd yet, as the REST hasn't been merged yet so I'm waiting for that.

@jaredmoo
Copy link
Contributor

No test implemented?

@cormacpayne
Copy link
Member

This PR should be merged at the same time as #2925 and #2927

@jaredmoo
Copy link
Contributor

Combined into #2927 . I'm closing this since it will be reviewed and merged as part of #2927.

@jaredmoo jaredmoo closed this Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants