Add ServiceFabric SDK by chingchenmsft · Pull Request #2903 · Azure/azure-sdk-for-net

chingchenmsft · 2017-03-07T06:00:46Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

azuresdkci · 2017-03-07T06:00:47Z

Can one of the admins verify this patch?

msftclas · 2017-03-07T06:00:50Z

@chingchenmsft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

cormacpayne · 2017-03-08T17:15:13Z

@azuresdkci add to whitelist

cormacpayne · 2017-03-08T17:15:23Z

Swagger spec: Azure/azure-rest-api-specs#984

cormacpayne · 2017-03-20T18:09:02Z

@chingchenmsft Hey Ching, could you please fill out the checklist provided at the top of the pull request before we continue with the review?

chingchenmsft · 2017-03-20T18:15:41Z

done the checklist.

cormacpayne

@chingchenmsft a few initial comments at first glance of the pull request

cormacpayne · 2017-03-20T21:16:00Z

+                        while (string.Compare(cluster.ClusterState, "ready",true) != 0)
+                        {
+                            cluster = serviceFabricClient.Clusters.Get(rg.Name, res.Name);
+                            System.Threading.Thread.Sleep(TimeSpan.FromMinutes(1));


@chingchenmsft please use TestUtilitiues.Wait() instead of Thread.Sleep() in your tests

cormacpayne · 2017-03-20T21:18:34Z

@@ -0,0 +1,61 @@
+{
+  "version": "1.0.0",


@chingchenmsft this should be 1.0.0-preview

cormacpayne · 2017-03-20T21:20:52Z

+@echo off
+set autoRestVersion=1.0.0-Nightly20170202
+if  "%1" == "" (
+    set specFile="https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-servicefabric/2016-09-01/swagger/servicefabric.json"


@chingchenmsft please change the URL to point at the commit you used, rather than the branch. I believe you would end up using this URL.

There is another PR is pending for review for the Swagger file, but the review should be a quick review mainly forces on description part., i will point it to the latest commit after it is done.

cormacpayne · 2017-03-20T21:21:11Z

+// by using the '*' as shown below:
+// [assembly: AssemblyVersion("1.0.*")]
+[assembly: AssemblyVersion("0.1.0.0")]
+[assembly: AssemblyFileVersion("0.1.0.0")]


@chingchenmsft both AssemblyVersion and AssemblyFileVersion should be 1.0.0.0

AssemblyFileVersion will always match the version found in project.json, and AssemblyVersion will never be updated, unless you bump the major version of the package, in which case the AssemblyVersion should also have its major version bumped

In the project.json, i am going to change it to "1.0.0-preview", so AssemblyFileVersion should be "1.0.0-preview" too ?

@chingchenmsft No, AssemblyFileVersion and AssemblyVersion do not use the -preview suffix, so both of them will be 1.0.0.0

okay, changed, thanks

cormacpayne · 2017-03-24T23:49:27Z

@chingchenmsft Hey Ching, can you push the fixes for the changes requested to your fork so the review is up to date?

chingchenmsft · 2017-04-01T14:31:03Z

sorry for keeping you waiting, i just waited for the latest Swagger checked in then pushed.

msftclas · 2017-04-04T00:07:55Z

@chingchenmsft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

* Support for version 2017-03-01 of Azure Traffic Manager REST API. Geographic profiles * Update test recordings for version 2017-03-01 * Update generated.cmd * Update generate.cmd with the exact commit in the spec repository for Traffic Manager 2017-03-01 * Virtual Network Gateway Connection tests for Ipsec Policy Added virtual network gateway connection tests for ipsec policies Added VirtualNetworkGatewayConnection Ipsec Policies Test record Test Cases updated to use field names Connection Ipsec Policies Test session data Ipsec policies Test added for virtual network gateway connections * Generated code for network new 2017-03-01 api-version (only Ipsec Policies added compared to previous swagger) * package version incremented * Adding E2E test for VM Put bug for protected members * [ACR] Update to 2017-03-01 version 1. Update getCredentials to listCredentials to support multiple login credentials. 2. Refine regenerateCredential to support regenerate the specified login credential. 3. Add Sku to registry properties as a required property. 4. Rename GetProperties to Get. 5. Change CreateOrUpdate to Create, add registry create parameters. * Addressing PR feedback, re-recording test after addressing feedback * Update swagger link * Capabilities and security policy features. Also renamed several types and operations for improved clarify and consistency. Additions: - BlobAuditingPolicy APIs (e.g. Databases.CreateOrUpdateBlobAuditingPolicy) - ThreatDetectionPolicy APIs (e.g. Databases.CreateOrUpdateThreatDetectionPolicy) - Databases.ListByServer now supports $expand parameter - Capabilities APIs (e.g. Capabilities.ListByLocation) Types renamed: - ServerFirewallRule -> FirewallRule - DatabaseEditions -> DatabaseEdition - ElasticPoolEditions -> ElasticPoolEdition - ImportRequestParameters -> ImportRequest - ExportRequestParameters -> ExportRequest - ImportExportOperationResponse -> ImportExportResponse - OperationMode -> ImportOperationMode - TransparentDataEncryptionStates -> TransparentDataEncryptionStatus Types removed: - Unused types: UpgradeHint, Schema, Table, Column Operations renamed: - Servers.GetByResourceGroup -> Servers.Get - Servers.CreateOrUpdateFirewallRule -> FirewallRule.CreateOrUpdate, and similar for Get, List, and Delete - Databases.Import -> Databases.CreateImportOperation - Servers.Import -> Databases.Import - Databases.PauseDataWarehouse -> Databases.Pause - Databases.ResumeDataWarehouse -> Databases.Resume Operations removed: - Removed ImportExport operation results APIs since these are handled automatically by Azure async pattern. * Add preview label * #WAF added autogenerated files * #WAF changed version in rest API calls of Network/SessionRecords. * #WAF changed version in rest API calls of Compute/SessionRecords. * #WAF set x-ms-flatten to true for ApplicationGatewayFirewallRuleSet. * Revert AssemblyVersion to 2.1.0 because there are no breaking changes in this version * Revert AssemblyVersion to 2.0.0 because there are no breaking changes in this version * Added license header * Removed UpgradeLog.htm * Restore copyright header to generated files * Using proper rest api spec for 2017-03-01 generation * #WAF Added web application firewall related tests and rerecorded agw tests. * #WAF removed unneccessary file ending changes created by the PS script for updating the api version number in SessionRecords. * #WAF updated comment for ApplicationGatewayFirewallDisabledRuleGroup.rules. * #WAF incremented assembly version. * Update Network test versions to 2017-03-01 * Update releasenotes to clarify breaking changes * corrected Assembly version for 2017-03-01 * #WAF removed redundancy in description of enums. * Fix Batch management plane releasenotes reference * #WAF updated required fields for getBackendHealth Api result. * #INIT updated the api-version to 2016-03-01 in the Network *Operation.cs files. * #INIT Updated Version number to 10.0.0 (next major version) since there will be breaking changes for application gateway. * #INIT Changed version number to 2017-03-01 in Network/SessionRecordings. * #INIT Changed version number to 2017-03-01 in Compute/SessionRecordings. * #INIT Removed unneccessary changes where only end of file chagned. * AssemblyInfo revert AssemblyVersion to original as requested * #WAF Renamed GetAvailableWafRuleSets to ListAvailableWafRuleSets. * removed EOF-only changes * Reverted global.json changes * #12345: Updating generated files after fixing virtualNetworkGateway resource swagger to remove unnecessary required params. * #WAF improved tests. * Updated RepoTask module with new supported KeyValue pairs (#2919) * Updated RepoTask module with new supported KeyVaule pairs * Updating properties of the manifest file * Generate XML documentation for all libraries. (#2959) * Turn XML generation on for all projects. * Exclude Batch due to lack of proper XML comments. * #WAF Recorded new ApplicationGateway tests. * Swagger and test update for ADL (#2995) * Swagger and test update for ADL This also uses the latest nightly AutoRest generator, which results in a touch of every file. * missed recording one test. * Update version of the ADL packages before PR merge * Update changelog for the current version. * Relay SDK Draft (#2998) * Adding Relay SDK Draft * Swagger Updates. * Method name corrected * Add ServiceFabric SDK (#2903) * Add ServiceFabric SDK * update with latest swagger file * update sdk with latest Swagger * update test case * update with latest swagger file * fix build warning * fix swagger file path * Search SDK: Bug fixes and JSON blob parsing support (#3012) * Search SDK: Fix bug that prevented infinite double values from deserializing Also added a bunch of test coverage around boundary values. * Search SDK: Adding convenience method for enabling JSON blob indexers * Search SDK: Bumping version to 3.0.3 and changing release notes * Updating Analyze API tests to include MS language tokenizers * Forgot about one case * Search SDK: Adding missing descriptions The Name properties of Tokenizer, TokenFilter, and CharFilter didn't have descriptions in the Swagger spec. Now that we've added them, the corresponding generated C# properties now have comments. * Key Vault soft-delete preview (#3021) * KeyVault: Add soft delete capability to C# SDK. - Includes session recording changes. * KeyVault: Add restore, backup, recover, purge perm. * KeyVault: Increase management SDK version. - 2.0.2 for official release of management SDK. * KeyVault: Add optin soft delete flag to key vaults. * Vault-level soft-delete support. * key vault package upgrade * adding purge disabled property for key and vault purge * Regenerate the SDK based on version 1.0.0 * Azure Machine Learning WebServicesRP new API version (#3036) * Initial change for a new version * Update the POST operation id * POST method update * Make the POST call long running operation and handle the request id. * Update existing test cases to work with new API version. * Add new test case for POST * Add test case for large payload scenario. * Description update according to swagger update * Update generate.cmd to point to new swagger spec * Suppress CredScan message for certificate thumbprint, which is for encryption, not auth. * Replace real thumbprints with dummy strings * More thumbprints replaced with dummy strings * Replace hardcoded web service keys with dummy strings * Replace keys and thumbprints with dummy strings * Remove all encrypted content which were treated as credentials by CredScan in the lab build. * Update .net SDK with the latest swagger. * exporting secret backup/restore in KV .net SDK (#3035) * exposing additional signing and encryption algorithms in the KeyVault .net SDK (#3040) * exporting secret backup/restore in KV .net SDK * Azure Machine Learning WebServicesRP new API version (#3036) * Initial change for a new version * Update the POST operation id * POST method update * Make the POST call long running operation and handle the request id. * Update existing test cases to work with new API version. * Add new test case for POST * Add test case for large payload scenario. * Description update according to swagger update * Update generate.cmd to point to new swagger spec * Suppress CredScan message for certificate thumbprint, which is for encryption, not auth. * Replace real thumbprints with dummy strings * More thumbprints replaced with dummy strings * Replace hardcoded web service keys with dummy strings * Replace keys and thumbprints with dummy strings * Remove all encrypted content which were treated as credentials by CredScan in the lab build. * Update .net SDK with the latest swagger. * exposing additional signing and encryption algorithms in the KeyVault .Net SDK

* Support for version 2017-03-01 of Azure Traffic Manager REST API. Geographic profiles * Update test recordings for version 2017-03-01 * Update generated.cmd * Update generate.cmd with the exact commit in the spec repository for Traffic Manager 2017-03-01 * Virtual Network Gateway Connection tests for Ipsec Policy Added virtual network gateway connection tests for ipsec policies Added VirtualNetworkGatewayConnection Ipsec Policies Test record Test Cases updated to use field names Connection Ipsec Policies Test session data Ipsec policies Test added for virtual network gateway connections * Generated code for network new 2017-03-01 api-version (only Ipsec Policies added compared to previous swagger) * package version incremented * Adding E2E test for VM Put bug for protected members * [ACR] Update to 2017-03-01 version 1. Update getCredentials to listCredentials to support multiple login credentials. 2. Refine regenerateCredential to support regenerate the specified login credential. 3. Add Sku to registry properties as a required property. 4. Rename GetProperties to Get. 5. Change CreateOrUpdate to Create, add registry create parameters. * Addressing PR feedback, re-recording test after addressing feedback * Update swagger link * Capabilities and security policy features. Also renamed several types and operations for improved clarify and consistency. Additions: - BlobAuditingPolicy APIs (e.g. Databases.CreateOrUpdateBlobAuditingPolicy) - ThreatDetectionPolicy APIs (e.g. Databases.CreateOrUpdateThreatDetectionPolicy) - Databases.ListByServer now supports $expand parameter - Capabilities APIs (e.g. Capabilities.ListByLocation) Types renamed: - ServerFirewallRule -> FirewallRule - DatabaseEditions -> DatabaseEdition - ElasticPoolEditions -> ElasticPoolEdition - ImportRequestParameters -> ImportRequest - ExportRequestParameters -> ExportRequest - ImportExportOperationResponse -> ImportExportResponse - OperationMode -> ImportOperationMode - TransparentDataEncryptionStates -> TransparentDataEncryptionStatus Types removed: - Unused types: UpgradeHint, Schema, Table, Column Operations renamed: - Servers.GetByResourceGroup -> Servers.Get - Servers.CreateOrUpdateFirewallRule -> FirewallRule.CreateOrUpdate, and similar for Get, List, and Delete - Databases.Import -> Databases.CreateImportOperation - Servers.Import -> Databases.Import - Databases.PauseDataWarehouse -> Databases.Pause - Databases.ResumeDataWarehouse -> Databases.Resume Operations removed: - Removed ImportExport operation results APIs since these are handled automatically by Azure async pattern. * Add preview label * #WAF added autogenerated files * #WAF changed version in rest API calls of Network/SessionRecords. * #WAF changed version in rest API calls of Compute/SessionRecords. * #WAF set x-ms-flatten to true for ApplicationGatewayFirewallRuleSet. * Revert AssemblyVersion to 2.1.0 because there are no breaking changes in this version * Revert AssemblyVersion to 2.0.0 because there are no breaking changes in this version * Added license header * Removed UpgradeLog.htm * Restore copyright header to generated files * Using proper rest api spec for 2017-03-01 generation * #WAF Added web application firewall related tests and rerecorded agw tests. * #WAF removed unneccessary file ending changes created by the PS script for updating the api version number in SessionRecords. * #WAF updated comment for ApplicationGatewayFirewallDisabledRuleGroup.rules. * #WAF incremented assembly version. * Update Network test versions to 2017-03-01 * Update releasenotes to clarify breaking changes * corrected Assembly version for 2017-03-01 * #WAF removed redundancy in description of enums. * Fix Batch management plane releasenotes reference * #WAF updated required fields for getBackendHealth Api result. * #INIT updated the api-version to 2016-03-01 in the Network *Operation.cs files. * #INIT Updated Version number to 10.0.0 (next major version) since there will be breaking changes for application gateway. * #INIT Changed version number to 2017-03-01 in Network/SessionRecordings. * #INIT Changed version number to 2017-03-01 in Compute/SessionRecordings. * #INIT Removed unneccessary changes where only end of file chagned. * AssemblyInfo revert AssemblyVersion to original as requested * #WAF Renamed GetAvailableWafRuleSets to ListAvailableWafRuleSets. * removed EOF-only changes * Reverted global.json changes * #12345: Updating generated files after fixing virtualNetworkGateway resource swagger to remove unnecessary required params. * #WAF improved tests. * Updated RepoTask module with new supported KeyValue pairs (#2919) * Updated RepoTask module with new supported KeyVaule pairs * Updating properties of the manifest file * Generate XML documentation for all libraries. (#2959) * Turn XML generation on for all projects. * Exclude Batch due to lack of proper XML comments. * #WAF Recorded new ApplicationGateway tests. * Swagger and test update for ADL (#2995) * Swagger and test update for ADL This also uses the latest nightly AutoRest generator, which results in a touch of every file. * missed recording one test. * Update version of the ADL packages before PR merge * Update changelog for the current version. * Relay SDK Draft (#2998) * Adding Relay SDK Draft * Swagger Updates. * Method name corrected * Add ServiceFabric SDK (#2903) * Add ServiceFabric SDK * update with latest swagger file * update sdk with latest Swagger * update test case * update with latest swagger file * fix build warning * fix swagger file path * Search SDK: Bug fixes and JSON blob parsing support (#3012) * Search SDK: Fix bug that prevented infinite double values from deserializing Also added a bunch of test coverage around boundary values. * Search SDK: Adding convenience method for enabling JSON blob indexers * Search SDK: Bumping version to 3.0.3 and changing release notes * Updating Analyze API tests to include MS language tokenizers * Forgot about one case * Search SDK: Adding missing descriptions The Name properties of Tokenizer, TokenFilter, and CharFilter didn't have descriptions in the Swagger spec. Now that we've added them, the corresponding generated C# properties now have comments. * Key Vault soft-delete preview (#3021) * KeyVault: Add soft delete capability to C# SDK. - Includes session recording changes. * KeyVault: Add restore, backup, recover, purge perm. * KeyVault: Increase management SDK version. - 2.0.2 for official release of management SDK. * KeyVault: Add optin soft delete flag to key vaults. * Vault-level soft-delete support. * key vault package upgrade * adding purge disabled property for key and vault purge * Regenerate the SDK based on version 1.0.0 * Azure Machine Learning WebServicesRP new API version (#3036) * Initial change for a new version * Update the POST operation id * POST method update * Make the POST call long running operation and handle the request id. * Update existing test cases to work with new API version. * Add new test case for POST * Add test case for large payload scenario. * Description update according to swagger update * Update generate.cmd to point to new swagger spec * Suppress CredScan message for certificate thumbprint, which is for encryption, not auth. * Replace real thumbprints with dummy strings * More thumbprints replaced with dummy strings * Replace hardcoded web service keys with dummy strings * Replace keys and thumbprints with dummy strings * Remove all encrypted content which were treated as credentials by CredScan in the lab build. * Update .net SDK with the latest swagger. * exporting secret backup/restore in KV .net SDK (#3035) * exposing additional signing and encryption algorithms in the KeyVault .net SDK (#3040) * exporting secret backup/restore in KV .net SDK * Azure Machine Learning WebServicesRP new API version (#3036) * Initial change for a new version * Update the POST operation id * POST method update * Make the POST call long running operation and handle the request id. * Update existing test cases to work with new API version. * Add new test case for POST * Add test case for large payload scenario. * Description update according to swagger update * Update generate.cmd to point to new swagger spec * Suppress CredScan message for certificate thumbprint, which is for encryption, not auth. * Replace real thumbprints with dummy strings * More thumbprints replaced with dummy strings * Replace hardcoded web service keys with dummy strings * Replace keys and thumbprints with dummy strings * Remove all encrypted content which were treated as credentials by CredScan in the lab build. * Update .net SDK with the latest swagger. * exposing additional signing and encryption algorithms in the KeyVault .Net SDK * RecoveryServicess on latest Swagger (#3028) * RecoveryServicess on latest Swagger * Updated generate cmd and project json with links * Added AssemblyInfo.cs file * Added license header and additional constructor for passing http client Using the ctor without root client handler

Add ServiceFabric SDK

4745c56

msftclas added the cla-not-required label Mar 7, 2017

update with latest swagger file

f3178a5

cormacpayne added the spec-not-merged label Mar 9, 2017

cormacpayne mentioned this pull request Mar 15, 2017

add service fabric swagger file Azure/azure-rest-api-specs#984

Merged

10 tasks

QingChenmsft added 2 commits March 20, 2017 10:14

update sdk with latest Swagger

af35904

update test case

b407868

cormacpayne removed the spec-not-merged label Mar 20, 2017

cormacpayne added the needs-revision label Mar 20, 2017

chingchenmsft self-assigned this Mar 20, 2017

chingchenmsft requested a review from cormacpayne March 20, 2017 18:24

cormacpayne suggested changes Mar 20, 2017

View reviewed changes

update with latest swagger file

14c3027

QingChenmsft added 2 commits April 1, 2017 10:05

fix build warning

7d77f79

fix swagger file path

00e7f09

cormacpayne closed this Apr 4, 2017

cormacpayne reopened this Apr 4, 2017

msftclas added the cla-not-required label Apr 4, 2017

cormacpayne approved these changes Apr 4, 2017

View reviewed changes

shahabhijeet merged commit 07cc2b3 into Azure:AutoRest Apr 4, 2017

abergs mentioned this pull request Apr 13, 2017

Add Service Fabric to Fluent API #3066

Closed

Conversation

chingchenmsft commented Mar 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

azuresdkci commented Mar 7, 2017

Uh oh!

msftclas commented Mar 7, 2017

Uh oh!

cormacpayne commented Mar 8, 2017

Uh oh!

cormacpayne commented Mar 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cormacpayne commented Mar 20, 2017

Uh oh!

chingchenmsft commented Mar 20, 2017

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Mar 24, 2017

Uh oh!

chingchenmsft commented Apr 1, 2017

Uh oh!

msftclas commented Apr 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chingchenmsft commented Mar 7, 2017 •

edited

Loading

cormacpayne commented Mar 8, 2017 •

edited

Loading