SDK updated for version 2017-03-01 of the Traffic Manager API#2900
Conversation
|
@vladca, |
markcowl
left a comment
There was a problem hiding this comment.
One comment about geenration in generate.cmd. Once your swagger spec is merged and you have made this change, this looks good.
| set autoRestVersion=0.16.0 | ||
| if "%1" == "" ( | ||
| set specFile="https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-trafficmanager/2015-11-01/swagger/trafficmanager.json" | ||
| set specFile="https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-trafficmanager/2017-03-01/swagger/trafficmanager.json" |
There was a problem hiding this comment.
Once the rest-api-specs PR is merged, you will need to update this to reference the last commit in that PR, and not the floating reference to 'master'
…Traffic Manager 2017-03-01
|
@azuresdki test this please |
|
@vladca it looks like you are used AutoRest 0.16.x to generate the code for this PR, which is a few months old. Please generate the code based off of the latest version of AutoRest (https://github.com/Azure/autorest#installing-autorest) You will also need to update the following items:
|
|
Cormac, please merge with version 0.16.0 for this update, I will upgrade to autorest 1.0+ with the next PR. All other comments (generate.cmd, assembly and package versions) were already addressed. |
|
|
||
| [assembly: AssemblyVersion("2.0.0.0")] | ||
| [assembly: AssemblyFileVersion("2.1.0.0")] | ||
| [assembly: AssemblyVersion("2.2.0.0")] |
There was a problem hiding this comment.
@vladca please keep AssemblyVersion at 2.0.0.
AssemblyFileVersion was the only version that should have changed, so it can remain at 2.2.0
|
@vladca please add back the Microsoft copyright header to all files. LGTM once this has been resolved |
Description
https://github.com/Azure/azure-rest-api-specs/pull/993/files
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.