Skip to content

SDK updated for version 2017-03-01 of the Traffic Manager API#2900

Merged
cormacpayne merged 7 commits into
Azure:AutoRestfrom
vladca:autorest_geo
Mar 20, 2017
Merged

SDK updated for version 2017-03-01 of the Traffic Manager API#2900
cormacpayne merged 7 commits into
Azure:AutoRestfrom
vladca:autorest_geo

Conversation

@vladca
Copy link
Copy Markdown

@vladca vladca commented Mar 6, 2017

Description

https://github.com/Azure/azure-rest-api-specs/pull/993/files

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
  • The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 6, 2017

@vladca,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Copy link
Copy Markdown
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about geenration in generate.cmd. Once your swagger spec is merged and you have made this change, this looks good.

set autoRestVersion=0.16.0
if "%1" == "" (
set specFile="https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-trafficmanager/2015-11-01/swagger/trafficmanager.json"
set specFile="https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-trafficmanager/2017-03-01/swagger/trafficmanager.json"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the rest-api-specs PR is merged, you will need to update this to reference the last commit in that PR, and not the floating reference to 'master'

@cormacpayne
Copy link
Copy Markdown
Member

@azuresdki test this please

@cormacpayne
Copy link
Copy Markdown
Member

@vladca it looks like you are used AutoRest 0.16.x to generate the code for this PR, which is a few months old. Please generate the code based off of the latest version of AutoRest (https://github.com/Azure/autorest#installing-autorest)

You will also need to update the following items:

@vladca
Copy link
Copy Markdown
Author

vladca commented Mar 20, 2017

Cormac, please merge with version 0.16.0 for this update, I will upgrade to autorest 1.0+ with the next PR. All other comments (generate.cmd, assembly and package versions) were already addressed.


[assembly: AssemblyVersion("2.0.0.0")]
[assembly: AssemblyFileVersion("2.1.0.0")]
[assembly: AssemblyVersion("2.2.0.0")]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladca please keep AssemblyVersion at 2.0.0.

AssemblyFileVersion was the only version that should have changed, so it can remain at 2.2.0

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, sorry

@cormacpayne
Copy link
Copy Markdown
Member

@vladca please add back the Microsoft copyright header to all files.

LGTM once this has been resolved

@cormacpayne cormacpayne merged commit 0862b42 into Azure:AutoRest Mar 20, 2017
@vladca vladca deleted the autorest_geo branch March 21, 2017 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants