Client Certificate auth for Confidential Ledger

[christothes]

#28640

docs changes in Azure/azure-sdk-tools#3320

[azure-sdk]

API change check for Azure.Security.ConfidentialLedger

API changes have been detected in Azure.Security.ConfidentialLedger. You can review API changes here

API changes

+         public ConfidentialLedgerClient(Uri ledgerUri, CertificateCredential certificateCredential, ConfidentialLedgerClientOptions options = null);

[azure-sdk]

API change check for Azure.Core

API changes have been detected in Azure.Core. You can review API changes here

API changes

+     public class CertificateCredential {
+         public CertificateCredential(X509Certificate2 certificate);
+         public X509Certificate2 ClientCertificate { get; }
+     }
+         public IList<CertificateCredential> ClientCertificates { get; }

[heaths]

1. You can't make local changes to eng/common. They need to be in Azure/azure-sdk-tools in the same directory.
2. Suggestion: I wouldn't rename (move) the .psm1. It's not needed with import-module -path, which we could also document if necessary.

[christothes]

1. You can't make local changes to eng/common. They need to be in Azure/azure-sdk-tools in the same directory.

Doh! I forgot about that.

2. Suggestion: I wouldn't rename (move) the .psm1. It's not needed with import-module -path, which we could also document if necessary.

I had some issues with -path not working consistently. I'm fine either way, but this seems to be more reliable.

[heaths]

I had some issues with -path not working consistently. I'm fine either way, but this seems to be more reliable.

I'm okay with that change then. The only reason for the block was local changes to eng/common. FWIW, I do like to test in a local repo like -net, but shouldn't check in like that.

[azure-sdk]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Security.ConfidentialLedger
Azure.Core

[check-enforcer]

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

[heaths]

I don't see anything blocking, but had a couple of nits and an open question (again, not blocking).

[heaths]

Given the merge commit - though GitHub somehow showed a "condensed version" (wonder when they added that nifty little feature) - I'd generally recommend rebasing + force push. Most often GitHub still shows reviewers only subsequent commits.

If one were to look at the whole merge commit:

I see that often in the specs repo and have them do a rebase instead.