Search SDK: Fix bug that prevented infinite double values from deserializing#2849
Merged
Merged
Conversation
…alizing Also added a bunch of test coverage around boundary values.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prior to this change, it was impossible to retrieve Double values from Azure Search if they were equal to positive or negative infinity. This is because the SDK was relying on JSON.NET's default behavior, which is to expect "Infinity" or "-Infinity", respectively. However, this is not how these values are serialized according to OData V4. In OData, they are "INF" and "-INF", respectively. To fix this, I added a new
DoubleConverter. I also added a bunch of test coverage around boundary values.Notes: We are not bumping the version yet because there are other changes we need to make first. Also, this is 100% changes to custom code; There are no corresponding Swagger changes.
FYI @chaosrealm @seansaleh @Yahnoosh @mhko
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.