Introducing new Microsoft.Azure.Monitor.dll for the Monitor team (formerly Insights)#2832
Merged
markcowl merged 15 commits intoAzure:AutoRestfrom Mar 3, 2017
Merged
Introducing new Microsoft.Azure.Monitor.dll for the Monitor team (formerly Insights)#2832markcowl merged 15 commits intoAzure:AutoRestfrom
markcowl merged 15 commits intoAzure:AutoRestfrom
Conversation
…he generate.cmd file
…into AutoRest # Conflicts: # src/ResourceManagement/Insights/Insights.Tests/project.json
Contributor
Author
|
The errors don't seem to be coming from our code, but from Data Lake's. |
Contributor
|
@azuresdkci test this please |
Member
|
@twitchax Please let us know how to handle this - should this be a new package, or a new version of Insights? It looks liek the namespaces in AzureRm have not changed. Needf to reach out to the PMs on the team to decide. |
Contributor
|
Based on previous discussions with them, this should be a separate package, and the old package will no longer ship (it was in preview). |
Contributor
|
Synced with them, and this should be a new package. |
Contributor
|
@markcowl: discussed the deprecation of the "Insights" package and redirection to the "Monitor" package...got the go ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introducing a new folder in this repo: monitor, which contains the code generated from the new Swagger specs folders called monitor, arm-monitor (PR merged recently Azure/azure-rest-api-specs#936).
With this we are effectively introducing a new SDK dll called Microsoft.Azure.Monitor.dll intended to replace Microsoft.Azure.Insights.dll.
The contents of the dlls are almost identical with these differences:
This name change is intended to avoid confusions with AppInsights artifacts and to align with the new name of our team.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.