Feature/jobatzil/connection draining#2824
Conversation
…ains only changes related to ConnectionDraining in ApplicationGateway and files which only change is the version number of the api calls.
… the network testrecordings from 2016-09-01 to 2016-12-01 using the script provided by Deepak (Because in azure-rest-api-specs we moved all missing files to the 2016-12-01 version folder, so the recordings needed to be adjusted!)
…ust the api-version.
…e compute test recordings from 2016-09-01 to 2016-12-01 using the script provided by Deepak.
…ject.json to 8.4.0*
|
Can one of the admins verify this patch? |
|
Hi @jobatzil, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
@azuresdkci add to whitelist |
|
@jobatzil do any of your test ran on the CI? Does it run locally? |
| /// <param name="etag">A unique read-only string that changes whenever | ||
| /// the resource is updated.</param> | ||
| public ApplicationGatewayBackendHttpSettings(string id = default(string), int? port = default(int?), string protocol = default(string), string cookieBasedAffinity = default(string), int? requestTimeout = default(int?), SubResource probe = default(SubResource), IList<SubResource> authenticationCertificates = default(IList<SubResource>), string provisioningState = default(string), string name = default(string), string etag = default(string)) | ||
| public ApplicationGatewayBackendHttpSettings(string id = default(string), int? port = default(int?), string protocol = default(string), string cookieBasedAffinity = default(string), int? requestTimeout = default(int?), SubResource probe = default(SubResource), IList<SubResource> authenticationCertificates = default(IList<SubResource>), string provisioningState = default(string), ApplicationGatewayConnectionDraining connectionDraining = default(ApplicationGatewayConnectionDraining), string name = default(string), string etag = default(string)) |
There was a problem hiding this comment.
@jobatzil any public surface area would require you to bump up major version due to breaking change.
There was a problem hiding this comment.
Since this is a preview library, that is unnecessary
|
Hey @shahabhijeet, yah all my tests were running. |
|
@jobatzil can you close this PR and reopen when you are ready to merge. Also when do you think you will be ready to merge (approx. days this PR needs to be kept open) |
| @@ -1092,4 +1092,4 @@ | |||
| "Variables": { | |||
There was a problem hiding this comment.
None of these changes that affect the line endings for compute json recordings should be there, pelase revery these
markcowl
dismissed
shahabhijeet’s stale review
Discussed offline, major version bump is not required
6 participants
Description
Added the support of ConnectionDraining for ApplicationGateway.
IMPORTANT
As can be seen in the PR linked below, we had to copy all files with no 2016-12-01 version yet to the 2016-12-01 folder to fix reference issues, which is why we had to adjust the test recordings of some files (in Network and Compute part).
Azure/azure-rest-api-specs#913
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.