ADL Preview Release Update#2803
Merged
cormacpayne merged 7 commits intoAzure:AutoRestfrom Feb 13, 2017
Merged
Conversation
added 4 commits
February 8, 2017 17:05
Recordings to follow.
Missed file in previous commit.
Contributor
Author
|
Here is the Swagger PR: Azure/azure-rest-api-specs#897 |
cormacpayne
suggested changes
Feb 9, 2017
Member
cormacpayne
left a comment
cormacpayne
left a comment
There was a problem hiding this comment.
@begoldsm couple of comments for clarification
| "Microsoft.Azure.Management.DataLake.Analytics": "[1.0.1-preview,2.0.0)", | ||
| "Microsoft.Azure.Management.DataLake.Store": "[1.0.1-preview,2.0.0)", | ||
| "Microsoft.Azure.Management.DataLake.Analytics": "[2.0.0-preview, 3.0.0-preview)", | ||
| "Microsoft.Azure.Management.DataLake.Store": "[2.0.0-preview, 3.0.0-preview)", |
Contributor
Author
There was a problem hiding this comment.
Good call, explicitly updated.
| "Microsoft.Rest.ClientRuntime": "[2.3.2,3.0)" , | ||
| "Microsoft.Azure.ResourceManager": "1.0.0-preview", | ||
| "Microsoft.Azure.Management.DataLake.Store": "2.0.0-preview", | ||
| "Microsoft.Azure.Management.DataLake.Store": "[2.0.0-preview, 3.0.0-preview)", |
| /// 'Commitment_10TB', 'Commitment_100TB', 'Commitment_500TB', | ||
| /// 'Commitment_1PB', 'Commitment_5PB'</param> | ||
| public DataLakeStoreAccountUpdateParameters(IDictionary<string, string> tags = default(IDictionary<string, string>), FirewallState? firewallState = default(FirewallState?), TrustedIdProviderState? trustedIdProviderState = default(TrustedIdProviderState?), string defaultGroup = default(string), TierType? newTier = default(TierType?)) | ||
| public DataLakeStoreAccountUpdateParameters(IDictionary<string, string> tags = default(IDictionary<string, string>), FirewallState? firewallState = default(FirewallState?), FirewallAllowAzureIpsState? firewallAllowAzureIps = default(FirewallAllowAzureIpsState?), TrustedIdProviderState? trustedIdProviderState = default(TrustedIdProviderState?), string defaultGroup = default(string), TierType? newTier = default(TierType?)) |
Member
There was a problem hiding this comment.
@begoldsm changing parameter order is a breaking change - should be fine since you are preview
Contributor
Author
There was a problem hiding this comment.
Oh good catch, and this is interesting. I wanted to keep all firewall related stuff together, but I am open to suggestions here. Do you think we should always just append parameters to the back, even when we are going to preview? This breaking change won't come in to stable for some time, and it will result in a major version bump (from 1.* to 2.*). Thoughts?
cormacpayne
approved these changes
Feb 13, 2017
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update includes the following:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.