Public HttpResponse class

[aliakb]

No description provided.

[andrerod]

Is this indententation and comment format normal ?

[aliakb]

Yes. It's 4 spaces per tabulation.

[andrerod]

? Dont you have to do field comments like the others bellow?

Sent from a phone

On 27/03/2012, at 09:24, "Aliaksei Baturytski" reply@reply.github.com wrote:

+using System.Collections.Generic;
+using System.Linq;
+using System.Net.Http;
+using System.Text;
+using System.Threading.Tasks;
+using NetHttpMethod = System.Net.Http.HttpMethod;
+using NetHttpRequestMessage = System.Net.Http.HttpRequestMessage;
+
+namespace Microsoft.WindowsAzure.ServiceLayer.Http
+{

• ///

• /// Represents an HTTP request.

• ///

• public sealed class HttpRequest

• {

•    private NetHttpMethod _method;                      // HTTP method verb.
  

Yes. It's 4 spaces per tabulation.

---

Reply to this email directly or view it on GitHub:
https://github.com/WindowsAzure/azure-sdk-for-net/pull/28/files#r609928

[aliakb]

Got it. This is a private member visible only to the class members; it won't be included into any autogenerated documentation. Adding a standard header here would be an overkill.

[andrerod]

I see... but I actually think it'd be just more consistent... This sort of comment for attributes seems weird / harder to read, wouldn't you agree ? If we're not using standard, might as well not include any at all... (but i'd still prefer the standard format :))

---

From: Aliaksei Baturytski [reply@reply.github.com]
Sent: Tuesday, March 27, 2012 9:36
To: André Rodrigues
Subject: Re: [azure-sdk-for-net] Public HttpResponse class (#28)

+using System.Collections.Generic;
+using System.Linq;
+using System.Net.Http;
+using System.Text;
+using System.Threading.Tasks;
+using NetHttpMethod = System.Net.Http.HttpMethod;
+using NetHttpRequestMessage = System.Net.Http.HttpRequestMessage;
+
+namespace Microsoft.WindowsAzure.ServiceLayer.Http
+{

• ///

• /// Represents an HTTP request.

• ///

• public sealed class HttpRequest

• {

•    private NetHttpMethod _method;                      // HTTP method verb.
  

Got it. This is a private member visible only to the class members; it won't be included into any autogenerated documentation. Adding a standard header here would be an overkill.

---

Reply to this email directly or view it on GitHub:
https://github.com/WindowsAzure/azure-sdk-for-net/pull/28/files#r610008

[aliakb]

This comment is valid from C# point of view, and here it represents just a note that I put for a future reader of this text. I don't thik we should go that far to declare strict rules on such minor things.