Skip to content

[SQL] Generate SDK for Endpoint Certificates API#27910

Merged
archerzz merged 18 commits intoAzure:mainfrom
ostojicb:sqlmi_endpoint_cert
May 5, 2022
Merged

[SQL] Generate SDK for Endpoint Certificates API#27910
archerzz merged 18 commits intoAzure:mainfrom
ostojicb:sqlmi_endpoint_cert

Conversation

@ostojicb
Copy link
Copy Markdown
Member

@ostojicb ostojicb commented Mar 31, 2022 •
edited
Loading

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

ostojicb
ostojicb commented Apr 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member Author

@ostojicb ostojicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swagger PR merged Azure/azure-rest-api-specs#18502

@ostojicb ostojicb marked this pull request as ready for review April 8, 2022 10:52
@ostojicb ostojicb requested a review from markcowl as a code owner April 8, 2022 13:47
@ostojicb
Copy link
Copy Markdown
Member Author

ostojicb commented Apr 11, 2022

Hi @m-nash, can you take a look?

archerzz
archerzz suggested changes Apr 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few breaking changes are found. It seems that some of them do not have backward compatibility (like removal of property). Please bump the major version to 3.0.0.0.

ostojicb
ostojicb commented Apr 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member Author

@ostojicb ostojicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the removal of delegatedResources and primaryDelegatedIdentityClientId in Database* files, this change has been applied to the API version that's currently in use - which means this change was already implicitly propagated to SDK and downstream clients.

For that reason, I am not sure if this SDK update itself is a breaking one (whether it requires a major version bump) Also, I couldn't find any references to these classes/props in PowerShell code.

For the reference, this is the PR that changed the current API version Azure/azure-rest-api-specs#18209
cc: @viparek

@ostojicb ostojicb requested a review from archerzz May 1, 2022 21:29
@ostojicb
Copy link
Copy Markdown
Member Author

ostojicb commented May 1, 2022

A few breaking changes are found. It seems that some of them do not have backward compatibility (like removal of property). Please bump the major version to 3.0.0.0.

We've reverted some breaking changes (from swagger). The one that's left (Delegation* stuff) is referring to already removed internal fields in the current API version - not sure if requires major version bump (3.0.0.0), but I updated it regardless.

@archerzz
Copy link
Copy Markdown
Member

archerzz commented May 4, 2022

Thanks @ostojicb Can you bump AssemblyVersion to 3.0.0.0 as well? See https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/78/Mgmt-.NET-SDK-release-process?anchor=signing-and-publishing-nuget-packges

@archerzz archerzz merged commit 365df55 into Azure:main May 5, 2022
paterasMSFT pushed a commit that referenced this pull request Jun 15, 2022
@ostojicb @paterasMSFT
[SQL] Generate SDK for Endpoint Certificates API (#27910)
982c517 
* initial generate

* Add tests

* run generate.ps1 script

* Bump versions

* revert collateral damage

* run generate.ps1, take 2

* revive replication links

* run generate.ps1

* bump to 3.0.0

* Bump AssemblyVersion
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
@ostojicb @zhihaoxue
[SQL] Generate SDK for Endpoint Certificates API (Azure#27910)
9fb0b6a 
* initial generate

* Add tests

* run generate.ps1 script

* Bump versions

* revert collateral damage

* run generate.ps1, take 2

* revive replication links

* run generate.ps1

* bump to 3.0.0

* Bump AssemblyVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@Yao725 Yao725 Awaiting requested review from Yao725

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@markcowl markcowl Awaiting requested review from markcowl

1 more reviewer

@archerzz archerzz archerzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@m-nash m-nash

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ostojicb @archerzz @m-nash