[Question Answering] Authoring Client Initialization#25348
[Question Answering] Authoring Client Initialization#25348heaths merged 9 commits intoAzure:mainfrom
Conversation
|
API changes have been detected in |
|
heaths
left a comment
There was a problem hiding this comment.
Overall looks great, but a couple of open questions we should probably resolve.
...elanguage/Azure.AI.Language.QuestionAnswering/src/Azure.AI.Language.QuestionAnswering.csproj
Outdated
Show resolved
Hide resolved
...zure.AI.Language.QuestionAnswering/api/Azure.AI.Language.QuestionAnswering.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...cognitivelanguage/Azure.AI.Language.QuestionAnswering/src/QuestionAnsweringProjectsClient.cs
Outdated
Show resolved
Hide resolved
sdk/cognitivelanguage/Azure.AI.Language.QuestionAnswering/src/autorest.md
Outdated
Show resolved
Hide resolved
|
API changes have been detected in |
|
As per @rokulka 's request and to be consistent with python, I've added transforms to ensure that the recent changes made to the operationIds in the swagger do not affect our SDK. I've also updated autorest.md to reference the latest swagger. |
...elanguage/Azure.AI.Language.QuestionAnswering/src/Azure.AI.Language.QuestionAnswering.csproj
Show resolved
Hide resolved
heaths
left a comment
There was a problem hiding this comment.
I'd make a tracking issue and reference it in the comment, but otherwise LGTM.
Hey all,
This PR is for initializing the QuestionAnswering authoring client. I have the following concerns:
The client is generated with the name
QuestionAnsweringProjectsClient, with a plural "projects". I think it makes sense to have the plural "projects" in the name of the client, and as such used the same for the namespace. Do we want the namespace to be...QuestionAnswering.Projectinstead?Using the
namespaceparameter in autorest.md does not actually set the namespace of the generated file(s). Not sure if this is a bug or if this some sort of mistake on my part, but I changed the namespace using the [CodeGenType] attribute. I left the syntax that I was using as a comment in autorest.md for demonstration.I removed the newly created options class as mentioned in the comment that was left in autorest.md. I would also like to note that we can keep the class but make it generate with a different name,
QuestionAnsweringProjectsClientOptionsfor example. This can be done by adding anotherTitleproperty in the autorest.md file for the generated swagger. This will be useful if we expect the runtime and authoring clients to have different version names and/or be out of sync with versioning.