SDK for 2021-11-01 version for Event Hubs with tests for SchemaRegistry #25314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damodaravadhani
requested review from
ArcturusZhang,
ArthurMa1978,
Yao725,
allenjzhang,
archerzz,
fengzhou-msft,
m-nash and
markcowl
as code owners
ghost
added
the
Member
|
Hi @damodaravadhani, There are some breaking changes in this PR. If they are expected, you need to bump the major version and then I will merge it. |
Yao725
approved these changes
Nov 19, 2021
Yao725
reviewed
Nov 26, 2021
| /// Key value set for keyType | ||
| /// </param> | ||
| public static AccessKeys RegenerateKeys(this IEventHubsOperations operations, string resourceGroupName, string namespaceName, string eventHubName, string authorizationRuleName, KeyType keyType, string key = default(string)) | ||
| public static AccessKeys RegenerateKeys(this IEventHubsOperations operations, string resourceGroupName, string namespaceName, string eventHubName, string authorizationRuleName, string keyType, string key = default(string)) |
Yao725
reviewed
Nov 26, 2021
| /// resource.</param> | ||
| public ArmDisasterRecovery(string id = default(string), string name = default(string), string type = default(string), ProvisioningStateDR? provisioningState = default(ProvisioningStateDR?), string partnerNamespace = default(string), string alternateName = default(string), RoleDisasterRecovery? role = default(RoleDisasterRecovery?), long? pendingReplicationOperationsCount = default(long?), SystemData systemData = default(SystemData)) | ||
| : base(id, name, type) | ||
| public ArmDisasterRecovery(string id = default(string), string name = default(string), string type = default(string), string location = default(string), ProvisioningStateDR? provisioningState = default(ProvisioningStateDR?), string partnerNamespace = default(string), string alternateName = default(string), RoleDisasterRecovery? role = default(RoleDisasterRecovery?), long? pendingReplicationOperationsCount = default(long?), SystemData systemData = default(SystemData)) |
Yao725
reviewed
Nov 26, 2021
| /// resource.</param> | ||
| public AuthorizationRule(IList<string> rights, string id = default(string), string name = default(string), string type = default(string), SystemData systemData = default(SystemData)) | ||
| : base(id, name, type) | ||
| public AuthorizationRule(IList<string> rights, string id = default(string), string name = default(string), string type = default(string), string location = default(string), SystemData systemData = default(SystemData)) |
Yao725
reviewed
Nov 26, 2021
| /// resource.</param> | ||
| public ConsumerGroup(string id = default(string), string name = default(string), string type = default(string), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), string userMetadata = default(string), SystemData systemData = default(SystemData)) | ||
| : base(id, name, type) | ||
| public ConsumerGroup(string id = default(string), string name = default(string), string type = default(string), string location = default(string), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), string userMetadata = default(string), SystemData systemData = default(SystemData)) |
Yao725
reviewed
Nov 26, 2021
| /// failed.</param> | ||
| public ErrorResponse(string code = default(string), string message = default(string)) | ||
| /// <param name="error">The error object.</param> | ||
| public ErrorResponse(ErrorDetail error = default(ErrorDetail)) |
Yao725
reviewed
Nov 26, 2021
| /// resource.</param> | ||
| public Eventhub(string id = default(string), string name = default(string), string type = default(string), IList<string> partitionIds = default(IList<string>), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), long? messageRetentionInDays = default(long?), long? partitionCount = default(long?), EntityStatus? status = default(EntityStatus?), CaptureDescription captureDescription = default(CaptureDescription), SystemData systemData = default(SystemData)) | ||
| : base(id, name, type) | ||
| public Eventhub(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IList<string> partitionIds = default(IList<string>), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), long? messageRetentionInDays = default(long?), long? partitionCount = default(long?), EntityStatus? status = default(EntityStatus?), CaptureDescription captureDescription = default(CaptureDescription), SystemData systemData = default(SystemData)) |
Yao725
reviewed
Nov 26, 2021
| /// resource.</param> | ||
| public NetworkRuleSet(string id = default(string), string name = default(string), string type = default(string), bool? trustedServiceAccessEnabled = default(bool?), string defaultAction = default(string), IList<NWRuleSetVirtualNetworkRules> virtualNetworkRules = default(IList<NWRuleSetVirtualNetworkRules>), IList<NWRuleSetIpRules> ipRules = default(IList<NWRuleSetIpRules>), string publicNetworkAccess = default(string), SystemData systemData = default(SystemData)) | ||
| : base(id, name, type) | ||
| public NetworkRuleSet(string id = default(string), string name = default(string), string type = default(string), string location = default(string), bool? trustedServiceAccessEnabled = default(bool?), string defaultAction = default(string), IList<NWRuleSetVirtualNetworkRules> virtualNetworkRules = default(IList<NWRuleSetVirtualNetworkRules>), IList<NWRuleSetIpRules> ipRules = default(IList<NWRuleSetIpRules>), string publicNetworkAccess = default(string), SystemData systemData = default(SystemData)) |
Yao725
reviewed
Nov 26, 2021
| /// <param name="display">Display of the operation</param> | ||
| /// <param name="origin">Origin of the operation</param> | ||
| /// <param name="properties">Properties of the operation</param> | ||
| public Operation(string name = default(string), bool? isDataAction = default(bool?), OperationDisplay display = default(OperationDisplay), string origin = default(string), object properties = default(object)) |
Yao725
reviewed
Nov 26, 2021
| /// resource.</param> | ||
| public PrivateEndpointConnection(string id = default(string), string name = default(string), string type = default(string), PrivateEndpoint privateEndpoint = default(PrivateEndpoint), ConnectionState privateLinkServiceConnectionState = default(ConnectionState), string provisioningState = default(string), SystemData systemData = default(SystemData)) | ||
| : base(id, name, type) | ||
| public PrivateEndpointConnection(string id = default(string), string name = default(string), string type = default(string), string location = default(string), PrivateEndpoint privateEndpoint = default(PrivateEndpoint), ConnectionState privateLinkServiceConnectionState = default(ConnectionState), string provisioningState = default(string), SystemData systemData = default(SystemData)) |
Yao725
reviewed
Nov 26, 2021
| /// <param name="key">Optional, if the key value provided, is set for | ||
| /// KeyType or autogenerated Key value set for keyType</param> | ||
| public RegenerateAccessKeyParameters(KeyType keyType, string key = default(string)) | ||
| public RegenerateAccessKeyParameters(string keyType, string key = default(string)) |
Yao725
reviewed
Nov 26, 2021
| /// Key value set for keyType | ||
| /// </param> | ||
| public static AccessKeys RegenerateKeys(this INamespacesOperations operations, string resourceGroupName, string namespaceName, string authorizationRuleName, KeyType keyType, string key = default(string)) | ||
| public static AccessKeys RegenerateKeys(this INamespacesOperations operations, string resourceGroupName, string namespaceName, string authorizationRuleName, string keyType, string key = default(string)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
Swagger spec link : Azure/azure-rest-api-specs#16363
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.