[Storage] Rename File#25025
Conversation
seanmcc-msft
requested review from
KrzysztofCwalina,
amishra-dev,
amnguye,
kasobol-msft and
tg-msft
as code owners
ghost
added
the
| [ServiceVersion(Min = ShareClientOptions.ServiceVersion.V2021_04_10)] | ||
| [TestCase(true)] | ||
| [TestCase(false)] | ||
| public async Task RenameAsync_ReplaceIfExists(bool replaceIfExists) |
There was a problem hiding this comment.
Note that apparently it is legal to overwrite a file with a directory, but not a directory with another directory.
| /// <summary> | ||
| /// Optional parameters for renaming a File or Directory. | ||
| /// </summary> | ||
| public class ShareFileRenameOptions |
There was a problem hiding this comment.
If these options are going to be used for both ShareFile and ShareDirectory, should the name be more like SharePathRenameOptions? I don't have a strong opinion on the name.
There was a problem hiding this comment.
Let's see what the arch board says.
|
API changes have been detected in API changes + V2021_02_12 = 10,
+ V2021_04_10 = 11,
+ public static BlobErrorCode SnapshotOperationRateExceeded { get; }
+ System = 2, |
|
API changes have been detected in |
|
API changes have been detected in API changes + V2021_02_12 = 10,
+ V2021_04_10 = 11,
+ System = 2, |
|
API changes have been detected in API changes + V2021_02_12 = 10,
+ V2021_04_10 = 11, |
| public Azure.Storage.Files.Shares.Models.ShareFileRequestConditions DestinationRequestConditions { get { throw null; } set { } } | ||
| public Azure.Storage.Files.Shares.Models.NtfsFileAttributes? FileAttributes { get { throw null; } set { } } | ||
| public System.DateTimeOffset? FileCreatedOn { get { throw null; } set { } } | ||
| public System.DateTimeOffset? FileLastWrittenOn { get { throw null; } set { } } |
There was a problem hiding this comment.
The spec also mentions x-ms-file-change-time, which we are missing in this class.
|
API changes have been detected in |
|
API changes have been detected in API changes - public const string DefaultSasVersion = "2021-02-12";
+ public const string DefaultSasVersion = "2021-04-10"; |
|
API changes have been detected in |
3 participants
No description provided.