Azure IOT Central updates for DotNet SDK release for RP version 2021-06-01 #24992

gansvv · 2021-10-28T19:59:31Z

Changes Included

This release removes legacy S1 SKU,
adds support for regions while removing geographies (for location),
releases new RP version 2021-06-01,
and adds support system-assigned Managed Identities in IoT Central.

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

This release removes legacy S1 SKU, has S360 fixes, releases new RP version 2021-06-01, and adds support for regional resources and system-assigned Managed Identities in IoT Central.

…nt SKUs. Updated package release notes, added tests for Managed Identities, added tests for validating exceptions from invalid SKUs.

sdk/iotcentral/Microsoft.Azure.Management.IotCentral/tests/ScenarioTests/IotCentralTestBase.cs

poanchen

LGTM

Updated default sku to be ST2.

archerzz

@gansvv There are a few constants deleted from the API, which is a breaking change. We need to bump the version to 4.0.0. Others looks fine. Thanks.

Updated version to 4.0.0 based on PR feedback.

gansvv · 2021-11-01T19:53:07Z

@gansvv There are a few constants deleted from the API, which is a breaking change. We need to bump the version to 4.0.0. Others looks fine. Thanks.

Thanks, I've updated version to 4.0.0. cc @archerzz

archerzz · 2021-11-02T07:20:22Z

@gansvv Pipeline is broken due to test failure. It seems that the test recordings are obsolete. Could you re-record the tests? Thanks.

Adding Session Records from execution of the IoTCentral DotNet SDK Tests

gansvv · 2021-11-03T17:10:21Z

@gansvv Pipeline is broken due to test failure. It seems that the test recordings are obsolete. Could you re-record the tests? Thanks.

Done. Added to PR.

Remove debug project ref to TestFramework

…ild failures for tests Removed randomization during session recording to prevent pipeline build failures for tests

…ecords Removed randomization from UpdateLIfeCycle tests and re-ran session records

Revert change to mgmtcommon file. https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/mgmtcommon/TestFramework/TestRecordAndFramework.sln

Minor update to match raw doc from Azure repo.

Add comment to trigger new build

…ling after 60mins. Increasing test pipeline timeout to 100mins since most builds are failing after 60mins. Matched build timeout in pipeline config.

archerzz

The codes look good. Please roll back the change in ci.mgmt.yml and packge-lock.json which will have impact on others as well.

Undo changes to test pipeline timeout and package-lock.json after syncing with Mingzhe Huang.

gansvv · 2021-11-05T01:59:05Z

The codes look good. Please roll back the change in ci.mgmt.yml and packge-lock.json which will have impact on others as well.

Done.

Minor: updated whitespace to match package-lock.json

archerzz · 2021-11-05T08:51:50Z

/check-enforcer override

archerzz · 2021-11-05T08:52:35Z

The test actually passes. The failure is due to timeout in macOS node, which should be fixed in pipeline.

…Identities Updated IoT Central Management Plane .Net package to 4.0.0. This version supports Managed Identities, removes support for S1 SKU, and supports only regional locations (not geographic). Related: .NET SDK update PR: Azure/azure-sdk-for-net#24992 Swagger update PR: Azure/azure-rest-api-specs#16139

…h support for Managed Identities (#16438) * Updated IoT Central DotNet package to 4.0.0 with support for Managed Identities Updated IoT Central Management Plane .Net package to 4.0.0. This version supports Managed Identities, removes support for S1 SKU, and supports only regional locations (not geographic). Related: .NET SDK update PR: Azure/azure-sdk-for-net#24992 Swagger update PR: Azure/azure-rest-api-specs#16139 * Minor updates to tests and changelog Minor updates to tests and changelog * Updated test session records. Updated test session records. * Update ChangeLog.md * Reverting module version Reverting module version and assembly version since they are computed per PR feedback. Co-authored-by: Yunchi Wang <[email protected]>

gansvv added 2 commits October 28, 2021 06:59

Updated for RP 2021-06-01 release

7b994a2

This release removes legacy S1 SKU, has S360 fixes, releases new RP version 2021-06-01, and adds support for regional resources and system-assigned Managed Identities in IoT Central.

Updated release notes, added tests for Managed Identities and differe…

0600978

…nt SKUs. Updated package release notes, added tests for Managed Identities, added tests for validating exceptions from invalid SKUs.

gansvv requested review from ArcturusZhang, ArthurMa1978, Yao725, allenjzhang, archerzz, fengzhou-msft, m-nash and markcowl as code owners October 28, 2021 19:59

openapi-assignment-bot bot assigned archerzz Oct 28, 2021

poanchen reviewed Oct 28, 2021

View reviewed changes

sdk/iotcentral/Microsoft.Azure.Management.IotCentral/tests/ScenarioTests/IotCentralTestBase.cs Outdated Show resolved Hide resolved

poanchen approved these changes Oct 28, 2021

View reviewed changes

Minor: Updated default Sku in test

19add1b

Updated default sku to be ST2.

archerzz suggested changes Nov 1, 2021

View reviewed changes

Updated version to 4.0.0

e2572ea

Updated version to 4.0.0 based on PR feedback.

Adding Session Records from execution of the IoTCentral DotNet SDK Tests

3d78fb6

Adding Session Records from execution of the IoTCentral DotNet SDK Tests

gansvv requested a review from AlexGhiondea as a code owner November 3, 2021 17:09

gansvv requested a review from archerzz November 3, 2021 21:20

gansvv added 7 commits November 3, 2021 15:19

Remove unused debug project ref to TestFramework

dde9d5e

Remove debug project ref to TestFramework

Removed randomization during session recording to prevent pipeline bu…

cfadea4

…ild failures for tests Removed randomization during session recording to prevent pipeline build failures for tests

Removed randomization from UpdateLIfeCycle tests and re-ran session r…

2bc3fc3

…ecords Removed randomization from UpdateLIfeCycle tests and re-ran session records

Revert change to mgmtcommon file

d41442c

Revert change to mgmtcommon file. https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/mgmtcommon/TestFramework/TestRecordAndFramework.sln

Minor update to sln

dd813bf

Minor update to match raw doc from Azure repo.

Add comment to trigger new build

4e9b825

Add comment to trigger new build

Increasing test pipeline timeout to 100mins since most builds are fai…

dc3bbe8

…ling after 60mins. Increasing test pipeline timeout to 100mins since most builds are failing after 60mins. Matched build timeout in pipeline config.

gansvv requested a review from chidozieononiwu as a code owner November 4, 2021 21:53

gansvv requested review from danieljurek and weshaggard as code owners November 4, 2021 21:53

archerzz approved these changes Nov 5, 2021

View reviewed changes

Undo changes to test pipeline timeout and package-lock.json

377be18

Undo changes to test pipeline timeout and package-lock.json after syncing with Mingzhe Huang.

Minor: update whitespace to match package-lock.json

a65fb91

Minor: updated whitespace to match package-lock.json

archerzz merged commit 8ad98e5 into Azure:main Nov 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Azure IOT Central updates for DotNet SDK release for RP version 2021-06-01 #24992

Azure IOT Central updates for DotNet SDK release for RP version 2021-06-01 #24992

Uh oh!

gansvv commented Oct 28, 2021 •

edited

Loading

Uh oh!

Uh oh!

poanchen left a comment

Uh oh!

archerzz left a comment

Uh oh!

gansvv commented Nov 1, 2021

Uh oh!

archerzz commented Nov 2, 2021

Uh oh!

gansvv commented Nov 3, 2021

Uh oh!

archerzz left a comment

Uh oh!

gansvv commented Nov 5, 2021

Uh oh!

archerzz commented Nov 5, 2021

Uh oh!

archerzz commented Nov 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Azure IOT Central updates for DotNet SDK release for RP version 2021-06-01 #24992

Azure IOT Central updates for DotNet SDK release for RP version 2021-06-01 #24992

Uh oh!

Conversation

gansvv commented Oct 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Included

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

SDK Generation Guidelines

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

Uh oh!

Uh oh!

poanchen left a comment

Choose a reason for hiding this comment

Uh oh!

archerzz left a comment

Choose a reason for hiding this comment

Uh oh!

gansvv commented Nov 1, 2021

Uh oh!

archerzz commented Nov 2, 2021

Uh oh!

gansvv commented Nov 3, 2021

Uh oh!

archerzz left a comment

Choose a reason for hiding this comment

Uh oh!

gansvv commented Nov 5, 2021

Uh oh!

archerzz commented Nov 5, 2021

Uh oh!

archerzz commented Nov 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gansvv commented Oct 28, 2021 •

edited

Loading