Skip to content

Test improvements for Queues/ServiceBus DynamicConcurrency (#24426)#24798

Closed
mathewc wants to merge 1 commit intomainfrom
dc-test-improvements
Closed

Test improvements for Queues/ServiceBus DynamicConcurrency (#24426)#24798
mathewc wants to merge 1 commit intomainfrom
dc-test-improvements

Conversation

@mathewc
Copy link
Copy Markdown
Member

@mathewc mathewc commented Oct 18, 2021

Addresses #24426 and #24745. Initially I was considering a larger overhaul of the tests, e.g. having a message writer that continued to write messages until concurrency increased by a certain amount. However, I think If we just adjust the message numbers and test conditions we should be able to arrive at a stable configuration.

@JoshLove-msft
Copy link
Copy Markdown
Member

/azp run net - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Copy Markdown
Contributor

/azp run net - storage - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Copy Markdown
Member

/azp run net - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Copy Markdown
Member

/azp run net - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Copy Markdown
Member

Looks like Service Bus tests are good - @kasobol-msft do you want to kick off the storage tests again or were there issues related to the dynamic concurrency tests in the previous run?

Copy link
Copy Markdown
Member

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from SB perspective.

@kasobol-msft
Copy link
Copy Markdown
Contributor

Looks like Service Bus tests are good - @kasobol-msft do you want to kick off the storage tests again or were there issues related to the dynamic concurrency tests in the previous run?

Yes, but we're not in position to do this right now as we're working on a regression in storage tests that destabilized pipelines.. @jaschrep-msft let's follow up here when we get pipelines in order.

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Dec 31, 2021
@ghost
Copy link
Copy Markdown

ghost commented Dec 31, 2021

Hi @mathewc. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Jan 7, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jan 7, 2022

Hi @mathewc. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@ArthurMa1978 ArthurMa1978 deleted the dc-test-improvements branch March 8, 2022 17:03
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Aug 1, 2023
Add Microsoft.StorageTasks Service | Swagger API Review (Ring 0 Service) (Azure#24798)

* Add the Readme files and StorageTasks Spec file with CRUD and List by subs and rg with examples

* Rectify provider namespace to Microsoft.StorageTask and refactor examples into folders

* Address Lint diff failure to use the model from common-types

* Update Operations API with defaut response

* Add List Storage Task Assignment ARM Ids API

* Add POST List Storage Task Run Report Summary API

* Adding x-ms-identifiers

* Spell corrections

* Fix spell check errors

* Add 201 response code to PUT task operation

* Address minor changes and comments to reuse existing schema, update examples

* Add request body to List Summary Report API, Add Example. Remove 200 status code from Delete Async

* Add example reference to API file

* Adding Storage task action preview API with example

* Correct spelling

* Addig allowed resource type constraint

* Change the Reporting API to GET with Arm resource type Microsoft.StorageTasks/storageTasks/reports

* Address PR comments, correct and rephrease operation ids

* Change to proxy resource

* Fix typo
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants